Moodle
  1. Moodle
  2. MDL-40870

Icon alt text in External Tool admin settings all read Accept

        Details

        • Testing Instructions:
          Hide
          1. Go to Admin settings for LTI under Plugins > Modules
          2. Add a new External Tool configuration, you can use http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php for the launch URL.
          3. Hover over External Tool action icons (or inspect source!) and verify that the alt text on the icons do not all read "Accept"
          Show
          Go to Admin settings for LTI under Plugins > Modules Add a new External Tool configuration, you can use http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php for the launch URL. Hover over External Tool action icons (or inspect source!) and verify that the alt text on the icons do not all read "Accept"
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:
        • Rank:
          51766

          Description

          If you go to the admin settings for External Tool (LTI), add a tool and then hover over the action icons, the alt text for each icon all read "Accept".

            Issue Links

            is a regression caused by

            Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-36802 LTI settings icon issues

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Michael de Raadt added a comment -

              Thanks for working on that, Mark.

              Show
              Michael de Raadt added a comment - Thanks for working on that, Mark.
              Hide
              Permalink
              Jason Fowler added a comment -

              Thanks Mark, the code is ready for integration - I assume it's a clean cherry pick back to the other branches?

              Show
              Jason Fowler added a comment - Thanks Mark, the code is ready for integration - I assume it's a clean cherry pick back to the other branches?
              Hide
              Permalink
              Sam Hemelryk added a comment - - edited

              Thanks Mark - this has been integrated now.

              Show
              Sam Hemelryk added a comment - - edited Thanks Mark - this has been integrated now.
              Hide
              Permalink
              Petr Škoda added a comment -

              this would be easy if you included some launch url and other necessary info to actually add some external tool instance, or am I missing something?

              Show
              Petr Škoda added a comment - this would be easy if you included some launch url and other necessary info to actually add some external tool instance, or am I missing something?
              Hide
              Permalink
              Mark Nielsen added a comment -

              Updated testing instructions.

              Show
              Mark Nielsen added a comment - Updated testing instructions.
              Hide
              Permalink
              Petr Škoda added a comment -

              thanks, works fine

              to integrators: please mark as tested

              Show
              Petr Škoda added a comment - thanks, works fine to integrators: please mark as tested
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Back to testing.

              Show
              Sam Hemelryk added a comment - Back to testing.
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better!

              "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar."
              ~ Professor Farnsworth

              Show
              Sam Hemelryk added a comment - Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better! "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar." ~ Professor Farnsworth

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: