Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40874

Retire MyMobile as a standard theme

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Install a site without the patch.
      2. Add some custom css in the MyMobile theme setting page.
      3. Set a course theme, user theme and category theme to MyMobile (you need to go in Appareance > Theme settings first to enable the three settings. Then you'll find each settings in in the course edit page, user profile and add course page.)
      4. In theme selector, set MyMobile to everything (legacy, mobile...).
      5. Reapply the patch.
      6. Upgrade
      7. Check that in the config_plugins and config_log tables there are no records with "plugin" field set to theme_mymobile.
      8. Check that the course, user, and category theme fallback to Clean.
      9. Check that the front page fallbacks to Clean on desktop and mobile.

      Test 2 (keeping MyMobile)

      1. Install a site without the patch.
      2. Add some custom css in the MyMobile theme setting page.
      3. In theme selector, set MyMobile as default.
      4. Apply the patch
      5. Download the mymobile them from Moodle.org https://moodle.org/plugins/pluginversion.php?id=4563 and copy back the file (alternatively read the theme/upgrade.txt, it must be clear what you are mean to do)
      6. Upgrade
      7. Check that everything is still set to MyMobile and that MyMobile settings still exists.
      Show
      Test 1 Install a site without the patch. Add some custom css in the MyMobile theme setting page. Set a course theme, user theme and category theme to MyMobile (you need to go in Appareance > Theme settings first to enable the three settings. Then you'll find each settings in in the course edit page, user profile and add course page.) In theme selector, set MyMobile to everything (legacy, mobile...). Reapply the patch. Upgrade Check that in the config_plugins and config_log tables there are no records with "plugin" field set to theme_mymobile. Check that the course, user, and category theme fallback to Clean. Check that the front page fallbacks to Clean on desktop and mobile. Test 2 (keeping MyMobile) Install a site without the patch. Add some custom css in the MyMobile theme setting page. In theme selector, set MyMobile as default. Apply the patch Download the mymobile them from Moodle.org https://moodle.org/plugins/pluginversion.php?id=4563 and copy back the file (alternatively read the theme/upgrade.txt, it must be clear what you are mean to do) Upgrade Check that everything is still set to MyMobile and that MyMobile settings still exists.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-40874-master-10
    • Story Points (Obsolete):
      20
    • Sprint:
      FRONTEND Sprint 6

      Description

      I'm not sure what the usage of the MyMobile theme is. It filled a need when we did not have any themes suitable for mobiles. However, the MyMobile theme is buggy and inconsistent with other Moodle standard themes. Some work has been done recently by Gareth J Barnard and Mary Evans.

      Now that we have responsive themes based on Bootstrap, I think we should consider retiring MyMobile.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  16 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    18/Nov/13