Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40893

process_question_answer queries the DB for each answer rather than per questions

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Create a quiz with a Multiple choice question.
      2. Duplicate the Quiz in the course.

      Ensure no errors.
      Ensure the answers to the questions are restored correctly by attempting the quiz.

      Show
      1. Create a quiz with a Multiple choice question. 2. Duplicate the Quiz in the course. Ensure no errors. Ensure the answers to the questions are restored correctly by attempting the quiz.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40893-master
    • Pull Master Diff URL:

      Description

      During restore, questions have the answers attached to them in a serial manner. However the database is queried for each answer because of the progressive parsing loader.

      Creating a small cache of the answers for a single question allows a reduction in database usage and also does a complete text match rather than the first 255 characters. Which does have the potential to expose the wrong answer to us.

      The memory requirement for a single question should not be large as any quiz page will be required to pay the same cost when displaying the answers to the quiz.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30018 Quiz Duplication With Carriage Return Results in a Fatal Error

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              mr-russ Russell Smith
              Reporter:
              mr-russ Russell Smith
              Peer reviewer:
              Tim Hunt
              Integrator:
              Dan Poltawski
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13