Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40897

Performance improvement in groups_get_activity_groupmode()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.1
    • Fix Version/s: 2.6
    • Component/s: Groups
    • Labels:
      None
    • Testing Instructions:
      Hide

      no functionality change. Just a quick test for regressions

      1. Create course and an assignment in separate group mode.
      2. Enrol two student and two teachers - one of each in group1 and one in group2 (make sure teacher can not accessallgroups)
      3. Submit assignments as both students, make sure each teacher can download only his group assignments
      Show
      no functionality change. Just a quick test for regressions Create course and an assignment in separate group mode. Enrol two student and two teachers - one of each in group1 and one in group2 (make sure teacher can not accessallgroups) Submit assignments as both students, make sure each teacher can download only his group assignments
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-40897-master

      Description

      groups_get_activity_groupmode() has an extra query to course table when passed argument is an instance of cm_info.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                marina Marina Glancy
                Reporter:
                marina Marina Glancy
                Integrator:
                Sam Hemelryk
                Tester:
                Frédéric Massart
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13