Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40898

windows unit tests failures in course upload tool

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.6
    • 2.6
    • Backup, Unit tests

      There was 1 error:
       
      1) tool_uploadcourse_helper_testcase::test_get_restore_content_dir
      rmdir(C:\server\phpu_moodledata/temp): Directory not empty
       
      C:\server\workspace\moodle24\lib\moodlelib.php:10535
      C:\server\workspace\moodle24\lib\testing\classes\util.php:593
      C:\server\workspace\moodle24\lib\phpunit\classes\util.php:222
      C:\server\workspace\moodle24\lib\phpunit\classes\advanced_testcase.php:86
       
      To re-run:
       C:\server\workspace\moodle24\vendor\phpunit\phpunit\composer\bin\phpunit tool_u
      ploadcourse_helper_testcase admin\tool\uploadcourse\tests\helper_test.php
      
      

      This is caused by sloppy file handle closing in backup/restore code, Windows can not delete dirs that contain open handles...

            skodak Petr Skoda
            skodak Petr Skoda
            Dan Poltawski Dan Poltawski
            Michael de Raadt Michael de Raadt
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.