Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40903

Split the persistent cache option into logical parts.

    XMLWordPrintable

Details

    • MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • 40903-26
    • Hide
      1. Run all unit tests
      2. Browse a site, log in, browse a course, make a forum post with an attached image.
      3. Check everything happens as expected.
      4. Visit Settings > Plugins > Caching > Configuration.
      5. Check there are no errors.
      Show
      Run all unit tests Browse a site, log in, browse a course, make a forum post with an attached image. Check everything happens as expected. Visit Settings > Plugins > Caching > Configuration. Check there are no errors.

    Description

      Presently setting the persistent cache option has two effects:

      1. The cache instance is held onto and future requests for it get given the original instance.
      2. Information passing through the cache is held onto in a static var for performance serving of subsequent requests.

      It's become apparent that really we need two options here.
      For example Fred's changes on MDL-13114.
      It makes no sense to use the static var for request caches - and doing so adds both processing and memory overhead.

      This change needs to be made and immediately applied to MDL-13114

      Attachments

        Issue Links

          Activity

            People

              samhemelryk Sam Hemelryk
              samhemelryk Sam Hemelryk
              Marina Glancy Marina Glancy
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Mark Nelson Mark Nelson
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Nov/13