Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40915

Replace add_to_log with an event trigger - calendar

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.7
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Create and edit an calendar event, make sure a log entry is added for the same, with all correct information as before.
      2. Create a chained event (repeated) , make sure a log entry is created for each of them.
      3. Edit all events of a chain, make sure a log entry is created for each of them.
      4. Delete a event, and make sure a log entry is created.
      5. Delete all events of a chain and make sure a log entry is created for each of them.
      Show
      Create and edit an calendar event, make sure a log entry is added for the same, with all correct information as before. Create a chained event (repeated) , make sure a log entry is created for each of them. Edit all events of a chain, make sure a log entry is created for each of them. Delete a event, and make sure a log entry is created. Delete all events of a chain and make sure a log entry is created for each of them.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40915-master
    • Pull Master Diff URL:
    • Story Points:
      20
    • Sprint:
      BACKEND Sprint 12

      Description

      Replace the add_to_log calls for the following area, with a call to the get_legacy_logdata function in the event class.

      Calendar
      /calendar/lib.php:2236: add_to_log($this->properties->courseid, 'calendar', 'add', 'event.php?action=edit&id='.$this->properties->id, $this->properties->name);
      /calendar/lib.php:2265: add_to_log($eventcopy->courseid, 'calendar', 'add', 'event.php?action=edit&id='.$eventcopyid, $eventcopy->name);
      /calendar/lib.php:2320: add_to_log($this->properties->courseid, 'calendar', 'edit all', 'event.php?action=edit&id='.$this->properties->id, $this->properties->name);
      /calendar/lib.php:2325: add_to_log($this->properties->courseid, 'calendar', 'edit', 'event.php?action=edit&id='.$this->properties->id, $this->properties->name);

      Suggested additional events:
      Check to see if deleting a calendar event requires an event.

        Attachments

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44370 Incorrect urls for calendar logs in log and loglive reports

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Petr Skoda
              Integrator:
              Marina Glancy
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14