Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40931

Separate user agent related functionality into its own library.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Run unit tests. (lib/tests/medialib_test.php, lib/tests/moodlelib_test.php, lib/tests/theme_config_test.php, lib/tests/useragent_test.php)
      2. Browse Moodle using a browser, phone and tablet make sure all work fine.
      3. Change the themes for different devices, make sure all works fine.
      4. Enable completion, view course as student, mark activities as completed
      5. View grader report
      6. Create groups in a course, add/remove members
      7. Embed media in textarea, make sure the player is displayed
      8. Download some file (for example from resource in a course)
      9. Check some pages in mymobile and clean themes
      10. Try to use any form containing a HTML editor in Firefox 23.0 (or similar). Ensure the HTML editor appears.

      there are more files affected, such as mod/lti, tabs, etc. Welcome to test them if you want

      Show
      Run unit tests. (lib/tests/medialib_test.php, lib/tests/moodlelib_test.php, lib/tests/theme_config_test.php, lib/tests/useragent_test.php) Browse Moodle using a browser, phone and tablet make sure all work fine. Change the themes for different devices, make sure all works fine. Enable completion, view course as student, mark activities as completed View grader report Create groups in a course, add/remove members Embed media in textarea, make sure the player is displayed Download some file (for example from resource in a course) Check some pages in mymobile and clean themes Try to use any form containing a HTML editor in Firefox 23.0 (or similar). Ensure the HTML editor appears. there are more files affected, such as mod/lti, tabs, etc. Welcome to test them if you want
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-40931-m26

      Description

      Separate the functionality we have in Moodle related to the user agent into its own library.
      The functionality I am talking about includes browser checks, browser support checks (svg etc) and device type stuff.

      Two real reasons to do this:

      1. Centralise and organise the functionality making it more manageable and easily maintained.
      2. Reduce the size of moodlelib.php (this was my initial drive)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              samhemelryk Sam Hemelryk
              Integrator:
              Damyon Wiese
              Tester:
              Jérôme Mouneyrac
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13