Moodle

When filtering user by access date the date fields should specify which field 'is before' and which field 'is after'.

Details

Description

Since 2.5 the filter form for user by access date is not usable. There are two date fields for each of ther filter selectors First access/Last access and Last modified but no text entry which field defines which filtering.

Solution:
add 'is after' in front of first date field and 'is before' in front of second date field for each of the selectors.

Issue Links

is a regression caused by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39463 Some usages of the date_selector do not use the optional parameter but use another checkbox meaning the calendar image is never disabled by the JS.

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rajesh Taneja added a comment -

Thanks for reporting this Ralf,

Adding patch for this and pushing it for review.

Show
Rajesh Taneja added a comment - Thanks for reporting this Ralf, Adding patch for this and pushing it for review.
Hide
Permalink
Rajesh Taneja added a comment -

Adding Mark as watcher, as he worked on MDL-39463

Show
Rajesh Taneja added a comment - Adding Mark as watcher, as he worked on MDL-39463
Hide
Permalink
Mark Nelson added a comment - - edited

Hi Ralf,

In 2.4 and earlier the user/filters/date.php file is using it's own logic for enabling and disabling the date selector fields, which is bad. In fact, you will notice that in 2.4 and earlier the date selector pop-up does not appear on this page at all. I went through and changed this logic completely so that the pop-up now appears and removed the unnecessary logic since the date_selector element allows you to pass the parameter 'optional' as true which renders a checkbox you can use to disable/enable the date.

Anyways, this looks fine Raj. This should be backported to 2.5 as well.

Show
Mark Nelson added a comment - - edited Hi Ralf, In 2.4 and earlier the user/filters/date.php file is using it's own logic for enabling and disabling the date selector fields, which is bad. In fact, you will notice that in 2.4 and earlier the date selector pop-up does not appear on this page at all. I went through and changed this logic completely so that the pop-up now appears and removed the unnecessary logic since the date_selector element allows you to pass the parameter 'optional' as true which renders a checkbox you can use to disable/enable the date. Anyways, this looks fine Raj. This should be backported to 2.5 as well.
Hide
Permalink
Mark Nelson added a comment -

The title gives the impression the date selector is completely borked, which it isn't.

Show
Mark Nelson added a comment - The title gives the impression the date selector is completely borked, which it isn't.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Mark, pushing it for integration.

Show
Rajesh Taneja added a comment - Thanks Mark, pushing it for integration.
Hide
Permalink
Marina Glancy added a comment -

Thanks, this was integrated in 2.5 and master

Show
Marina Glancy added a comment - Thanks, this was integrated in 2.5 and master
Hide
Permalink
Petr Škoda added a comment -

works fine, thanks

Show
Petr Škoda added a comment - works fine, thanks
Hide
Permalink
Sam Hemelryk added a comment -

Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better!

"The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar."
~ Professor Farnsworth

Show
Sam Hemelryk added a comment - Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better! "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar." ~ Professor Farnsworth

People

Vote (0)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: