Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40937

Assignment history cannot be opened in IE8/IE9

    Details

    • Testing Instructions:
      Hide

      Using ie8 or ie 9 with the developer tools closed.

      Login to an assignment with attempt reopen method set to manual, make a submission, login as a teacher, mark the submission and allow another attempt, login as the student, check that you can see the previous attempt on the assignment submission page.

      Show
      Using ie8 or ie 9 with the developer tools closed. Login to an assignment with attempt reopen method set to manual, make a submission, login as a teacher, mark the submission and allow another attempt, login as the student, check that you can see the previous attempt on the assignment submission page.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-40937_assignment_history

      Description

      With the new Moodle 2.5 resubmission feature active and at least one resubmission granted, visit either the assignment view page (as a student) or the grade one assignment page (as a teacher).

      The 'previous attempts' section does not open in IE8 or IE9 due to 'console' being undefined (line 14 of mod/assign/yui/history/history.js) - the problem disappears in IE9 when the developer tools are open (as this defines the 'console' global variable).

      I will submit a patch to remove the line.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            damyon Damyon Wiese added a comment -

            Looks fine to me - thanks for fixing this Davo.

            Show
            damyon Damyon Wiese added a comment - Looks fine to me - thanks for fixing this Davo.
            Hide
            samhemelryk Sam Hemelryk added a comment - - edited

            Thanks Davo + Damyon - this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - - edited Thanks Davo + Damyon - this has been integrated now.
            Hide
            salvetore Michael de Raadt added a comment -

            Test result: Success!

            Tested in IE8, IE9 and IE10 (for good measure).

            Show
            salvetore Michael de Raadt added a comment - Test result: Success! Tested in IE8, IE9 and IE10 (for good measure).
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better!

            "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar."
            ~ Professor Farnsworth

            Show
            samhemelryk Sam Hemelryk added a comment - Huzzah, your code made it into Moodle. Perhaps now things are ever so slightly better! "The ship can't take this much pressure. Sometimes it falls apart just sitting in the hangar." ~ Professor Farnsworth

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/13