Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40953

Section renderer should always output the <ul> tag

XMLWordPrintable

    • MOODLE_25_STABLE
    • MOODLE_26_STABLE
    • Hide

      Please be diligent and try with a number of course formats, including some of those in the plugin directory.

      • Open a course
      • Confirm that the HTML structure for an empty section is valid - it should have:
        • An empty <ul></ul>
      • Confirm that the HTML structure for a section with content is valid - it should have:
        • An <ul> tag
        • some course modules in that list.
      • Test that moving sections, modules, and blocks still works as it did before.
      Show
      Please be diligent and try with a number of course formats, including some of those in the plugin directory. Open a course Confirm that the HTML structure for an empty section is valid - it should have: An empty <ul></ul> Confirm that the HTML structure for a section with content is valid - it should have: An <ul> tag some course modules in that list. Test that moving sections, modules, and blocks still works as it did before.

      Having to conditionally add an unordered list in our JavaScript is a right pain in the back-side and makes it very difficult to get right for course formats.

      We should always create the <ul> element, even for empty sections. This will vastly simplify our JavaScript.

      I've had a quick look at all of the renderers for contributed course formats, and none of these overwrites the cm_list function. If one were to do so in the future, then they would either not support the existing JS code anyway so no features are lost.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Marina Glancy Marina Glancy
            Sam Hemelryk Sam Hemelryk
            Adrian Greeve Adrian Greeve
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.