Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 2.6
Affects Version/s: 2.6
Component/s: Blocks, Libraries
Labels:
- triaged

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Epic Link:
Additional name field debugging issues.
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Main Branch:
~~MDL-40962~~-master
Pull Main Diff URL:
https://github.com/ankitagarwal/moodle/compare/c78fdd8...MDL-40962-master
Testing Instructions:
Hide

Please make sure you can see the warnings without the patch before testing with patch.

You need a course with atleast one assign activity with a recent submission.

Add recent activity block to the course.

Set fullnamedisplay setting to 'firstname, lastnamephonetic'.

Login as a user who does not have permissions of 'moodle/site:viewfullnames'

Make sure there are no warnings in the recent activity block

Run phpunit mod_assign_lib_testcase and make sure it passes without any debugging notices.
Show
Please make sure you can see the warnings without the patch before testing with patch. You need a course with atleast one assign activity with a recent submission. Add recent activity block to the course. Set fullnamedisplay setting to 'firstname, lastnamephonetic'. Login as a user who does not have permissions of 'moodle/site:viewfullnames' Make sure there are no warnings in the recent activity block Run phpunit mod_assign_lib_testcase and make sure it passes without any debugging notices.

Story Points:
5
Sprint:
BACKEND Sprint 5

When an assignment has been submitted, the recent activity displays this:

You need to update your sql to include additional name fields in the user object.

line 3657 of /lib/moodlelib.php: call to debugging()

line 2222 of /lib/weblib.php: call to fullname()

line 587 of /mod/assign/lib.php: call to print_recent_activity_note()

line ? of unknownfile: call to assign_print_recent_activity()

line 8362 of /lib/moodlelib.php: call to call_user_func_array()

line 202 of /blocks/recent_activity/block_recent_activity.php: call to component_callback()

line 74 of /blocks/recent_activity/block_recent_activity.php: call to block_recent_activity->get_modules_recent_activity()

line 296 of /blocks/moodleblock.class.php: call to block_recent_activity->get_content()

line 238 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()

line 956 of /lib/blocklib.php: call to block_base->get_content_for_output()

line 1008 of /lib/blocklib.php: call to block_manager->create_block_contents()

line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()

line 7 of /theme/base/layout/general.php: call to block_manager->region_has_content()

line 847 of /lib/outputrenderers.php: call to include()

line 777 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()

line 242 of /course/view.php: call to core_renderer->header()

You need to update your sql to include additional name fields in the user object.

line 3657 of /lib/moodlelib.php: call to debugging()

line 2222 of /lib/weblib.php: call to fullname()

line 587 of /mod/assign/lib.php: call to print_recent_activity_note()

line ? of unknownfile: call to assign_print_recent_activity()

line 8362 of /lib/moodlelib.php: call to call_user_func_array()

line 202 of /blocks/recent_activity/block_recent_activity.php: call to component_callback()

line 74 of /blocks/recent_activity/block_recent_activity.php: call to block_recent_activity->get_modules_recent_activity()

line 296 of /blocks/moodleblock.class.php: call to block_recent_activity->get_content()

line 238 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()

line 956 of /lib/blocklib.php: call to block_base->get_content_for_output()

line 1008 of /lib/blocklib.php: call to block_manager->create_block_contents()

line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()

line 7 of /theme/base/layout/general.php: call to block_manager->region_has_content()

line 847 of /lib/outputrenderers.php: call to include()

line 777 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()

line 242 of /course/view.php: call to core_renderer->header()

You need to update your sql to include additional name fields in the user object.

line 3657 of /lib/moodlelib.php: call to debugging()

line 2222 of /lib/weblib.php: call to fullname()

line 587 of /mod/assign/lib.php: call to print_recent_activity_note()

line ? of unknownfile: call to assign_print_recent_activity()

line 8362 of /lib/moodlelib.php: call to call_user_func_array()

line 202 of /blocks/recent_activity/block_recent_activity.php: call to component_callback()

line 74 of /blocks/recent_activity/block_recent_activity.php: call to block_recent_activity->get_modules_recent_activity()

line 296 of /blocks/moodleblock.class.php: call to block_recent_activity->get_content()

line 238 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()

line 956 of /lib/blocklib.php: call to block_base->get_content_for_output()

line 1008 of /lib/blocklib.php: call to block_manager->create_block_contents()

line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()

line 7 of /theme/base/layout/general.php: call to block_manager->region_has_content()

line 847 of /lib/outputrenderers.php: call to include()

line 777 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()

line 242 of /course/view.php: call to core_renderer->header()

You need to update your sql to include additional name fields in the user object.

line 3657 of /lib/moodlelib.php: call to debugging()

line 2222 of /lib/weblib.php: call to fullname()

line 587 of /mod/assign/lib.php: call to print_recent_activity_note()

line ? of unknownfile: call to assign_print_recent_activity()

line 8362 of /lib/moodlelib.php: call to call_user_func_array()

line 202 of /blocks/recent_activity/block_recent_activity.php: call to component_callback()

line 74 of /blocks/recent_activity/block_recent_activity.php: call to block_recent_activity->get_modules_recent_activity()

line 296 of /blocks/moodleblock.class.php: call to block_recent_activity->get_content()

line 238 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()

line 956 of /lib/blocklib.php: call to block_base->get_content_for_output()

line 1008 of /lib/blocklib.php: call to block_manager->create_block_contents()

line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()

line 7 of /theme/base/layout/general.php: call to block_manager->region_has_content()

line 847 of /lib/outputrenderers.php: call to include()

line 777 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()

line 242 of /course/view.php: call to core_renderer->header()

Not sure how to replicate this, but I followed the instructions of ~~MDL-40897~~ and that came up while logged in as the student.

has been marked as being related by

MDL-31776 Additional name fields, to allow Asian languages to flexibly display user names in Chinese characters, local phonetic system or Romanization

Closed

Testing discovered

MDL-40897 Performance improvement in groups_get_activity_groupmode()

Closed

Assignee:: Ankit Agarwal

Reporter:: Frédéric Massart

Peer reviewer:: Adrian Greeve

Integrator:: Damyon Wiese

Tester:: Andrew Davis

Participants:: Adrian Greeve, Andrew Davis, Ankit Agarwal, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 31/Jul/13 12:56 PM

Updated:: 14/Oct/13 5:05 PM

Resolved:: 11/Oct/13 10:11 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify