MDL-40065 claims the issue is fixed in 2.5.1, but I'm still experiencing it when adding outcome items.

Prior to clicking 'add outcome item'

I'm still seeing this issue when trying to import outcomes as well. I am also seeing it when using the Ad-hoc reporting tool. I'm on Moodle 2.5.2 currently.

We're also seeing this when attempting to import outcomes, with 2.5.2+. The issue exists in 2.6 as well.

I've attached a screenshot from qa.moodle.net.

We've found that adding:

$PAGE->set_pagelayout('admin');

to grade/edit/outcome/import.php made the error go away.

What was the layout set to prior to you changing it? We can't just keep changing CORE code to make Bootstrap themes work, we need to fix Bootstrapbase theme to stop it playing silly games!

It was not set to anything. I added that line.

Well it appears to the a problem in Standard themes too, at least I am getting errors in Standard theme.

Adding Michael de Raadt is there any chance we can get this fixed?
Eloy thinks it's related to MDL-34311 and so told me to PING you

I think I figured it out...just need to test it in Clean. I got standard to work OK.

Michael, if you have time can you Peer Review this please or assign it to someone else?

Thanks
Mary

Thanks for the patch Mary, Patch looks spot-on. Only thing which I can suggest is the git commit message. It seems too long http://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages

[y] Syntax
[y] Whitespace
[y] Output
[-] Language
[-] Databases
[y] Testing (instructions and automated tests)
[-] Security
[-] Documentation
[y] Git
[-] Third party code
[y] Sanity check

Feel free to push it for integration when ready.

Thanks Rajesh I realised that the commit was a bit too long, I'll clean it up thanks.

Hello Mary.
Thanks a lot for working on it. Patch looked a little suspicious for me because it has nothing to do with Clean theme. The same page having incorrect layout in Standard theme does not throw an error. So I started digging and this is what I found.

1. Your change in setType() is absolutely correct

2. Your change in setting pagelayout is half-correct. Function print_grade_page_head() sets the page layout but it is called too late. The form constructor accesses the $OUTPUT and pagelayout must not be changed after that. Correct would be to move print_grade_page_head() above the form constructor and not to not add another set_pagelayout . At the same time I searched the code calling print_grade_page_head() and absolutely everywhere we do the same - instead of calling the function early we add another set_pagelayout in the beginning, or even worse, do this:
https://github.com/moodle/moodle/blob/master/grade/edit/letter/index.php#L60

3. But still - in case of calling set_pagelayout too late Clean should not die. I looked at how layouts process block regions in base/standard and made a similar correction. Except that I added this check inside the function core_renderer::blocks() and not inside the layout files like base/standard/etc do:

diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php

index 56b6f56..5a0bf27 100644

--- a/lib/outputrenderers.php

+++ b/lib/outputrenderers.php

@@ -3199,7 +3199,12 @@ EOD;

             'data-blockregion' => $displayregion,

             'data-droptarget' => '1'

         );

-        return html_writer::tag($tag, $this->blocks_for_region($region), $attributes);

+        if ($this->page->blocks->region_has_content($region, $this)) {

+            $content = $this->blocks_for_region($region);

+        } else {

+            $content = '';

+        }

+        return html_writer::tag($tag, $content, $attributes);

     }

     /**

I'm going to integrate this patch as it is but I recommend you to consider making some patch for Clean theme so it does not vomit when we set page layout too late.

Thanks, integrated in 2.4, 2.5, 2.6

Tested, all good

Hi Marina,

I'm not sure how to do what you ask, are you suggesting I make a change to theme/bootstrap/renderers/core_renderer.php similar to your code (3) above? Or are you telling me I need to add something in theme/clean/layouts?

Hi Mary, I'm not 100% sure. I created an issue MDL-40971 and maybe Sam can help there

Congratulations - this issue has been included in Moodle and is now available on our git mirrors and shortly will become available on the download servers shortly.