Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.5.1, 2.7.4, 2.8.2
-
Component/s: Web Services
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
-
Fixed Branches:MOODLE_27_STABLE, MOODLE_28_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-41026-master -
Pull Master Diff URL:
Description
Hi,
I have issues with the delete_notes WS functions...After a review of the notes/externallib.php code review, a fix could be, on line 229:
$params = self::validate_parameters(self::delete_notes_parameters(), array('notes' => $notes));
Instead of:
$params = self::validate_parameters(self::delete_notes_parameters(), $notes);
The errors I have with the WS function are:
Calling parameters do not match signature
(If I incorporate the 'notes' index that is missing) Or
Missing required key in single structure: notes
(If I do not incorporate it...)
As I have tested all the combinations possible for the WS function parameter, I hope it is not a misunderstanding on my side...