Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41050

Progress bar size parameter does not work

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      1. Place the attached testprogress.php file in the root of your Moodle installation.

      2. Run the file. The page should show 2 progress bars, one 500 pixels wide and one 700 pixels wide (each with border). Below each progress bar is a box that was manually created with matching width.

      EXPECTED:

      The two boxes are precisely aligned with the progress bars. Both progress bars look correct.

      Show
      1. Place the attached testprogress.php file in the root of your Moodle installation. 2. Run the file. The page should show 2 progress bars, one 500 pixels wide and one 700 pixels wide (each with border). Below each progress bar is a box that was manually created with matching width. EXPECTED: The two boxes are precisely aligned with the progress bars. Both progress bars look correct.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-41050-master

      Description

      The progress bar class has a size parameter which defaults to 500. There is nowhere in Moodle code that uses any value other than 500 for this parameter.

      There are two problems:

      1. The progress bar is centered slightly incorrectly because the size it uses does not take into account 2 pixels of border (i.e. something should be 502, not 500).

      2. The width value is ignored at the key point, meaning the width option doesn't actually change the width of the bar. This seems like rather a flaw in the width option.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13