Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41063

Lesson qformat_default class is missing an error function

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.5
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide

      Import the (bogus !) attached sample_with_images.zip file using "Blackboard" format in a lesson.
      Verify that an error message:
      Error importing question Could not find question data file in zip
      File could not be read, or was empty
      And not a fatal error:
      Fatal error: Call to undefined method qformat_blackboard_six::error() in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 147
      is displayed.

      Note: If you test this with debugging set to DEVELOPER level, you will also see the warning explaining the problem in the file:
      Warning: DOMDocument::load() [<a href='domdocument.load'>domdocument.load</a>]: Namespace prefix bb for title on resource is not defined in file:///C:/wamp/moodledata_head/temp/bbquiz_import/1375862828/imsmanifest.xml, line: 7 in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 106
      But that is expected

      Show
      Import the (bogus !) attached sample_with_images.zip file using "Blackboard" format in a lesson. Verify that an error message: Error importing question Could not find question data file in zip File could not be read, or was empty And not a fatal error: Fatal error: Call to undefined method qformat_blackboard_six::error() in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 147 is displayed. Note: If you test this with debugging set to DEVELOPER level, you will also see the warning explaining the problem in the file: Warning: DOMDocument::load() [<a href='domdocument.load'>domdocument.load</a>] : Namespace prefix bb for title on resource is not defined in file:///C:/wamp/moodledata_head/temp/bbquiz_import/1375862828/imsmanifest.xml , line: 7 in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 106 But that is expected
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Lesson use the same plugins as the question bank but define it's own qformat_default class.
      This class should have an error function defined because if not and if something goes wrong during import we get a fatal error like:
      Fatal error: Call to undefined method qformat_blackboard_six::error() in C:\wamp\www\moodle_head\question\format\blackboard_six\format.php on line 147

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14