Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41084

Exception throwing in MUC cache loading causes ungraceful fallback to non-cache

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.5.1
    • Fix Version/s: None
    • Component/s: Caching
    • Labels:

      Description

      We recently faced an error during unserialisation of a .cache file (only as admin) in MDLSITE-2373. This may have been due to the file being incompletely replicated (and hence corrupt). The issue was that @unserialise() was failing at several byte lengths. This cause an exception to be thrown which wasn't handled anywhere up the chain really.

      several ideas were:
      1) verify cache file integrity, perhaps a message digest but this could be too much overhead for a caching system.
      2) change throwing exception to debugging message instead - doesn't solve but avoid unnecessary fatalism error to user.
      3) handle the exceptions in the loaders

      a patch is linked to for (2).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              nebgor Aparup Banerjee
              Integrator:
              Sam Hemelryk
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              3 Vote for this issue
              Watchers:
              14 Start watching this issue

                Dates

                Created:
                Updated: