Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38189 META Backup/restore issues with large courses
  3. MDL-41087

Backup progress: add progress tracking inside long-running steps

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.1
    • Fix Version/s: 2.6
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      1. If you haven't got one already, create the 'M' sized test course using Site administration / Development / Make test course.

      2. Do a backup of this course using default settings on all screens.

      EXPECTED: Backup completes successfully including the progress bar display.

      NOTE: As a result of this change, there should be fewer/shorter pauses than before in which both the progress bar isn't moving, and also the wibbler (bar below it) isn't pulsating. Nearly all of the time, one or other of those things should be happening. However this is a bit hard to quantify so I'm not considering it part of the test.

      Show
      1. If you haven't got one already, create the 'M' sized test course using Site administration / Development / Make test course. 2. Do a backup of this course using default settings on all screens. EXPECTED: Backup completes successfully including the progress bar display. NOTE: As a result of this change, there should be fewer/shorter pauses than before in which both the progress bar isn't moving, and also the wibbler (bar below it) isn't pulsating. Nearly all of the time, one or other of those things should be happening. However this is a bit hard to quantify so I'm not considering it part of the test.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-41087-master

      Description

      The new progress bar in backup and restore automatically updates for each task/step. In some cases, a step may take a long time. We should add progress tracking within these steps. This will make the progress bar smoother and reduce the possibility of timeouts for larger courses.

      I am attaching a trace of times in the backup run for the 'L' size test course. I've manually annotated this to mark tasks that take more than a couple of seconds with **, these are (in order of time taken):

      17:01:25: backup_users_structure_step users ** 105s
      16:57:54: backup_roles_structure_step course_roles** 33s
      16:58:58: backup_forum_activity_structure_step forum structure** 33s
      16:57:25: backup_enrolments_structure_step course_enrolments** 29s
      16:58:29: move_inforef_annotations_to_final migrate_inforef** 24s
      17:01:05: backup_annotate_all_user_files user_files ** 20s
      17:03:10: backup_final_files_structure_step fileslist ** 11s
      17:04:27: backup_store_backup_file save_backupfile ** 7s
      17:03:24: backup_zip_contents zip_contents ** 3s

      I'll investigate all these steps to see which ones we can add progress information for.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                quen Sam Marshall
                Reporter:
                quen Sam Marshall
                Peer reviewer:
                Dan Poltawski
                Integrator:
                Marina Glancy
                Tester:
                Mark Nelson
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13