Moodle
  1. Moodle
  2. MDL-41098

Add Atto HTML editor to core (the editor formally known as contenteditable)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
    • Testing Instructions:
      Hide

      Go to Administration -> Plugins -> Text Editors
      Enable the HTML 5 Text Editor and move it to the top of the list.

      Try it on different browsers in different areas of Moodle: (Some suggestions are forum, course settings, create a quiz multiple choice question).

      Note the list of subtasks on this issue for improvements already raised.

      Try it on a phone.
      Get your Mum to try it on her iPad.
      Try it on a "Chrome Pixel (you might need to buy this yourself)"
      Try it on a palm pilot

      Show
      Go to Administration -> Plugins -> Text Editors Enable the HTML 5 Text Editor and move it to the top of the list. Try it on different browsers in different areas of Moodle: (Some suggestions are forum, course settings, create a quiz multiple choice question). Note the list of subtasks on this issue for improvements already raised. Try it on a phone. Get your Mum to try it on her iPad. Try it on a "Chrome Pixel (you might need to buy this yourself)" Try it on a palm pilot
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41098-master
    • Story Points:
      20
    • Rank:
      52026
    • Sprint:
      FRONTEND Sprint 4

      Description

      Add contenteditable text editor to core (non default).

      Link to plugins DB:
      https://moodle.org/plugins/view.php?plugin=editor_contenteditable

      Link to github:
      https://github.com/damyon/contenteditable

      Also needs: MDL-40493 to allow users to set their choice of editor in their preferences.

      Reasoning:

      1. TinyMCE has bugs in iOS that we have been unable to solve in a reasonable amount of time. This editor is much simpler - so less to debug/maintain. We can leave tinymce as the default - but use this editor on iOS spcifically where tinyMCE fails.
      2. It fits with Moodle better - it uses YUI for window management, and event handling - and uses moodle pix_icons etc - so the UI "fits" better with Moodle.

      Things to do:

      Change the name? - done - rename to "HTML5 text editor"

      Change the icons? - only for consistency. Can be done when icons are ready.

      If this is to be a core editor it needs to support enough of the features that TinyMCE supports so that it is not seen as worse.
      Some things tinyMCE does that contenteditable does not:

      • Image alignment
      • Maths plugins
      • Colors
      • Fonts
      • Paste from word (Is this really needed?)
      • More...
      1. html.png
        188 kB
      2. linkDialog.png
        178 kB
      3. pretty.png
        170 kB
      4. Screen Shot 2013-08-26 at 10.57.43.png
        106 kB
      5. scrollup.png
        172 kB

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Imorted the branch from my git repo. This is ready for a review.

          Show
          Damyon Wiese added a comment - Imorted the branch from my git repo. This is ready for a review.
          Hide
          Martin Dougiamas added a comment -

          Peer reviewers please post comments as you go!

          Show
          Martin Dougiamas added a comment - Peer reviewers please post comments as you go!
          Hide
          Andrew Davis added a comment -

          When I checked out the branch "HTML5 text editor" was disabled in Site Admin manage editors. Once I enabled it and moved it up the list of editors it appeared.

          Show
          Andrew Davis added a comment - When I checked out the branch "HTML5 text editor" was disabled in Site Admin manage editors. Once I enabled it and moved it up the list of editors it appeared.
          Hide
          Andrew Davis added a comment -

          There doesnt seem to be any visible sign that a button is toggled. If Im typing and click the bold button then shift the focus back to the text field there's no way to know that bold is on aside from simply typing and seeing what happens. It gets weird as soon as you starting turning multiple things on and off as you have to keep the state in you head.

          Show
          Andrew Davis added a comment - There doesnt seem to be any visible sign that a button is toggled. If Im typing and click the bold button then shift the focus back to the text field there's no way to know that bold is on aside from simply typing and seeing what happens. It gets weird as soon as you starting turning multiple things on and off as you have to keep the state in you head.
          Hide
          Andrew Davis added a comment - - edited

          The text box size changes if you toggle back and forth between wysiwyg and html mode.

          https://tracker.moodle.org/secure/attachment/34114/pretty.png

          https://tracker.moodle.org/secure/attachment/34113/html.png

          Also, when you are in html mode the other buttons are disabled but the visual difference is very subtle. If my eyesight was less good I suspect the difference would be invisible.

          Show
          Andrew Davis added a comment - - edited The text box size changes if you toggle back and forth between wysiwyg and html mode. https://tracker.moodle.org/secure/attachment/34114/pretty.png https://tracker.moodle.org/secure/attachment/34113/html.png Also, when you are in html mode the other buttons are disabled but the visual difference is very subtle. If my eyesight was less good I suspect the difference would be invisible.
          Hide
          Andrew Davis added a comment - - edited

          In tinymce we offer heading 1 through 6, paragraph, preformatted and address. preformatted and address are a little cryptic...

          In the new editor there is title, heading, quoted and plain. Looking at the html title is h1 and heading is h2. Do we just want to call them heading 1 and heading 2 as they are in tinymce? Do we still want to provide all the way up to h6? Maybe just to 4?

          Show
          Andrew Davis added a comment - - edited In tinymce we offer heading 1 through 6, paragraph, preformatted and address. preformatted and address are a little cryptic... In the new editor there is title, heading, quoted and plain. Looking at the html title is h1 and heading is h2. Do we just want to call them heading 1 and heading 2 as they are in tinymce? Do we still want to provide all the way up to h6? Maybe just to 4?
          Hide
          Andrew Davis added a comment -

          If you expand the drop down containing title, heading etc clicking elsewhere doesnt close it. You can click back in the text box and keep typing and it stays expanded. Pretty minor but a bit unexpected. You can close it by clicking on the button you used to expand it.

          Show
          Andrew Davis added a comment - If you expand the drop down containing title, heading etc clicking elsewhere doesnt close it. You can click back in the text box and keep typing and it stays expanded. Pretty minor but a bit unexpected. You can close it by clicking on the button you used to expand it.
          Hide
          Andrew Davis added a comment - - edited

          https://tracker.moodle.org/secure/attachment/34115/linkDialog.png

          Regardless of the scroll position the link dialog displays slightly off the bottom of my screen. 13" laptop if that is relevant. I can drag it up but if I close it and reopen it it goes back to the bottom of the screen.

          Also notice that the dotted line from the file area shows through.

          And if I click the link button in the editor without having any text selected, nothing happens.

          If I select text, make it a link then keep typing the typing goes into the display text of the link. I can't see how to "break out" of the link short of jumping into html view. Simply clicking the unlink button doesn't seem to help. In tinymce I select text, make it a link then any additional typing appears after the link.

          I can select text, "unlink" to remove the link entirely but, similar to the link button, it gives me no sign that its even registered the click if I just click it with nothing selected. Perhaps both the link and the unlink button should be visibly disabled until text is selected.

          To try and edit a link I reselected a link and pressed the link button. Link URL was empty so I re-entered it. The result was a nested link.

          <a id="yui_3_9_1_3_1376534829364_2306" href="http://moodle.org"><a href="http://moodle2.org">moodle.org</a><br></a>
          

          There doesnt seem to be any way to set a link target ie same window, new window. This seems important. If I'm provided a set of links in the forum (or wherever) I'll almost certainly want them to open in a new window.

          Show
          Andrew Davis added a comment - - edited https://tracker.moodle.org/secure/attachment/34115/linkDialog.png Regardless of the scroll position the link dialog displays slightly off the bottom of my screen. 13" laptop if that is relevant. I can drag it up but if I close it and reopen it it goes back to the bottom of the screen. Also notice that the dotted line from the file area shows through. And if I click the link button in the editor without having any text selected, nothing happens. If I select text, make it a link then keep typing the typing goes into the display text of the link. I can't see how to "break out" of the link short of jumping into html view. Simply clicking the unlink button doesn't seem to help. In tinymce I select text, make it a link then any additional typing appears after the link. I can select text, "unlink" to remove the link entirely but, similar to the link button, it gives me no sign that its even registered the click if I just click it with nothing selected. Perhaps both the link and the unlink button should be visibly disabled until text is selected. To try and edit a link I reselected a link and pressed the link button. Link URL was empty so I re-entered it. The result was a nested link. <a id= "yui_3_9_1_3_1376534829364_2306" href= "http: //moodle.org" ><a href= "http://moodle2.org" >moodle.org</a><br></a> There doesnt seem to be any way to set a link target ie same window, new window. This seems important. If I'm provided a set of links in the forum (or wherever) I'll almost certainly want them to open in a new window.
          Hide
          Andrew Davis added a comment - - edited

          On the insert image dialog I suspect the "browse repositories" button should be above all the text boxes. Most people are presumably going to use that button and then the text boxes are all filled in automatically. That way the dialog opens, "browse repositories" is at the top to select/upload a file, the text fields are filled automatically and the preview is displayed with the "insert image" button below it.

          The insert media dialog is similar.

          Clicking outside the insert image dialog doesnt close it. Not sure if it should.

          It does not appear to be possible make an image into a link. In tinymce I add the image, click it, click the link button and my image is put within an a tag. In the new editor, selecting the image and clicking the link button doesn't seem to do anything.

          On my laptop the insert image dialog is displayed with the close dialog X off the top of the screen. I can drag it down but maybe it would be better to have the top onscreen and require the user to scroll down to see the bottom.
          https://tracker.moodle.org/secure/attachment/34116/scrollup.png
          Note the page scrollbar position. I can scroll down but not up. I have to grab that narrow strip of dark grey and pull the dialog down.

          Show
          Andrew Davis added a comment - - edited On the insert image dialog I suspect the "browse repositories" button should be above all the text boxes. Most people are presumably going to use that button and then the text boxes are all filled in automatically. That way the dialog opens, "browse repositories" is at the top to select/upload a file, the text fields are filled automatically and the preview is displayed with the "insert image" button below it. The insert media dialog is similar. Clicking outside the insert image dialog doesnt close it. Not sure if it should. It does not appear to be possible make an image into a link. In tinymce I add the image, click it, click the link button and my image is put within an a tag. In the new editor, selecting the image and clicking the link button doesn't seem to do anything. On my laptop the insert image dialog is displayed with the close dialog X off the top of the screen. I can drag it down but maybe it would be better to have the top onscreen and require the user to scroll down to see the bottom. https://tracker.moodle.org/secure/attachment/34116/scrollup.png Note the page scrollbar position. I can scroll down but not up. I have to grab that narrow strip of dark grey and pull the dialog down.
          Hide
          Andrew Davis added a comment -

          None of the buttons have tooltips. For users on a regular computer they are nice.

          Tinymce give you the ability to toggle LTR and RTL. Does the new editor use the user/site language and automatically format correctly?

          Tinymce allows you to insert tables. Not sure if that functionality is important. Generally tinymce offers a lot of manual control. Colors, alignment etc. Stuff I suspect we can do without, at least if the new editor is going to be a light weight fallback for tinymce.

          Show
          Andrew Davis added a comment - None of the buttons have tooltips. For users on a regular computer they are nice. Tinymce give you the ability to toggle LTR and RTL. Does the new editor use the user/site language and automatically format correctly? Tinymce allows you to insert tables. Not sure if that functionality is important. Generally tinymce offers a lot of manual control. Colors, alignment etc. Stuff I suspect we can do without, at least if the new editor is going to be a light weight fallback for tinymce.
          Hide
          Andrew Davis added a comment -

          I think that's it. Generally it works nicely as a clean light weight editor It just has some quirks that need to be ironed out.

          Show
          Andrew Davis added a comment - I think that's it. Generally it works nicely as a clean light weight editor It just has some quirks that need to be ironed out.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          Andrew reviewed the UI/usability, I'll just comment about the code.

          Previously said to Damyon, some minor comments:

          • no need for license file and README file (readme useful information should be in the UI for the admin that sometimes can not check the server files)
            lang/en/editor_contenteditable.php:
          • comment about tinymce
            lib/editor/contenteditable/lib.php:
          • supports_repositories(): set to false but it looks it works (weird)
          • no need to have head_setup() or call parent function - the method is not abstract, so some content could be added.
          • some /* ...code... */
          • remove all code from $context=... to $langrev=... as the three variables instancied are not used
          • you might rename open_browser() in open_filepicker ()
          • remove console.log();

          Well done Damyon, it's some pretty clean and structured js.

          Note: it does miss a lot of features. At the moment it's mainly cool for phone as on phone the user is likely to do less than on a desktop (my assumption). Would it be useful to have in the administration a way to order the editor for phone only? I totally can see people asking for all tinymce features to be integrated into this editor and then we'll end up with two tinymce... I'm a bit worry about the situation. Maybe the solution is in fact to make a phone editor that is only displayed on phone, and in this case I think the issue deserve a bit more time in the specification/mockup/usability tests phase.

          Show
          Jérôme Mouneyrac added a comment - - edited Andrew reviewed the UI/usability, I'll just comment about the code. Previously said to Damyon, some minor comments: no need for license file and README file (readme useful information should be in the UI for the admin that sometimes can not check the server files) lang/en/editor_contenteditable.php: comment about tinymce lib/editor/contenteditable/lib.php: supports_repositories(): set to false but it looks it works (weird) no need to have head_setup() or call parent function - the method is not abstract, so some content could be added. some /* ...code... */ remove all code from $context=... to $langrev=... as the three variables instancied are not used you might rename open_browser() in open_filepicker ( ) remove console.log(); Well done Damyon, it's some pretty clean and structured js. Note: it does miss a lot of features. At the moment it's mainly cool for phone as on phone the user is likely to do less than on a desktop (my assumption). Would it be useful to have in the administration a way to order the editor for phone only? I totally can see people asking for all tinymce features to be integrated into this editor and then we'll end up with two tinymce... I'm a bit worry about the situation. Maybe the solution is in fact to make a phone editor that is only displayed on phone, and in this case I think the issue deserve a bit more time in the specification/mockup/usability tests phase.
          Hide
          Damyon Wiese added a comment -

          Thanks for the reviews.

          So we can get more people to comment on and work on this I'll fix the code related issues so we can get this version integrated and create new issues for any changes to the functionality.

          Show
          Damyon Wiese added a comment - Thanks for the reviews. So we can get more people to comment on and work on this I'll fix the code related issues so we can get this version integrated and create new issues for any changes to the functionality.
          Hide
          Damyon Wiese added a comment -

          Pushed a new branch with these fixes:

          • Remove license and readme
          • Remove unused and commented code
          • Add missing phpdocs
          • Make enabled by default
          • Allow making images links
          • Lets you edit existing links
          • Added doc comments + licenses to all

          It looks in pretty good shape now - I'll create some new issues for the functionality changes listed above so we can discuss them.

          Show
          Damyon Wiese added a comment - Pushed a new branch with these fixes: Remove license and readme Remove unused and commented code Add missing phpdocs Make enabled by default Allow making images links Lets you edit existing links Added doc comments + licenses to all It looks in pretty good shape now - I'll create some new issues for the functionality changes listed above so we can discuss them.
          Hide
          Martin Dougiamas added a comment -

          Damyon can you come up with a new unique name for your editor? (Whatever you like)

          I feel HTML5 or contenteditable are too generic (you can't google for this editor currently).

          Show
          Martin Dougiamas added a comment - Damyon can you come up with a new unique name for your editor? (Whatever you like) I feel HTML5 or contenteditable are too generic (you can't google for this editor currently).
          Hide
          CiBoT added a comment -

          Results for MDL-41098

          Show
          CiBoT added a comment - Results for MDL-41098 Branch MDL-41098 -master to be integrated into upstream master Executed job http://ci.stronk7.com/job/Precheck%20remote%20branch/533 Execution status: 0 Details: http://ci.stronk7.com/job/Precheck%20remote%20branch/533/artifact/work/smurf.html
          Hide
          Dan Poltawski added a comment - - edited

          Hi Damyon,

          In addition to the comments from martin and cibot:

          1. The use of the @author phpdocs tag. This was mentioned IRL in the office last week and it has brought it into my mind. A lot of these phpdocs tags were discussed in the documentation sprint (which took place just before I started for HQ) and as its not mentioned in the coding guidelines I believe it is intentionally not used. I think we rely on the git history for that. And in fact, I think that Martin intentionally prefered the copyright attribution to be distributed (hehe, I shouldn't speculate on something like that that). Also, you're doing it inconsistently across the files.
          2. Misleading comment:
            //== Custom Moodle strings that are not part of upstream TinyMCE ==
            
          3. Different naming:
            //  YUI text editor integration.
            
          4. Trailing whitespace in lib/editor/contenteditable/lib.php
          Show
          Dan Poltawski added a comment - - edited Hi Damyon, In addition to the comments from martin and cibot: The use of the @author phpdocs tag. This was mentioned IRL in the office last week and it has brought it into my mind. A lot of these phpdocs tags were discussed in the documentation sprint (which took place just before I started for HQ) and as its not mentioned in the coding guidelines I believe it is intentionally not used. I think we rely on the git history for that. And in fact, I think that Martin intentionally prefered the copyright attribution to be distributed (hehe, I shouldn't speculate on something like that that). Also, you're doing it inconsistently across the files. Misleading comment: //== Custom Moodle strings that are not part of upstream TinyMCE == Different naming: // YUI text editor integration. Trailing whitespace in lib/editor/contenteditable/lib.php
          Hide
          Dan Poltawski added a comment -

          (failing for now)

          Show
          Dan Poltawski added a comment - (failing for now)
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Damyon Wiese added a comment -

          I came up with "Atto text editor".

          (pico, nano, ...)

          Show
          Damyon Wiese added a comment - I came up with "Atto text editor". (pico, nano, ...)
          Hide
          Damyon Wiese added a comment -

          Renamed the editor - I squashed the commits because of the rename (it didn't make sense in the history).

          All codechecker and moodlecheck warnings and errors are fixed.

          All copyright/license tags are consistent and author tags removed.

          Show
          Damyon Wiese added a comment - Renamed the editor - I squashed the commits because of the rename (it didn't make sense in the history). All codechecker and moodlecheck warnings and errors are fixed. All copyright/license tags are consistent and author tags removed.
          Hide
          Dan Poltawski added a comment - - edited

          Hi Damyon,

          1. In my IE10 it doesn't look to be working properly. The box is too small and I can't edit in it (attached screenshot)
          2. Which raised a question - is this going to work fine in older verisons of IE? (Despite wanting to get rid of browser sniffing, i'm wondering if there is a case for falling back to tinymce for some compatibility)
          3. Trivial: get_init_params() has a couple of unused globals
          Show
          Dan Poltawski added a comment - - edited Hi Damyon, In my IE10 it doesn't look to be working properly. The box is too small and I can't edit in it (attached screenshot) Which raised a question - is this going to work fine in older verisons of IE? (Despite wanting to get rid of browser sniffing, i'm wondering if there is a case for falling back to tinymce for some compatibility) Trivial: get_init_params() has a couple of unused globals
          Hide
          Damyon Wiese added a comment -

          Thanks Dan,

          I'll check it in ie 10 - I have tested it in ie 7, 8 and 9 and it works fine (ie was actually one of the first browsers to support this).

          I'll add a fix the unused globals.

          Show
          Damyon Wiese added a comment - Thanks Dan, I'll check it in ie 10 - I have tested it in ie 7, 8 and 9 and it works fine (ie was actually one of the first browsers to support this). I'll add a fix the unused globals.
          Hide
          Martin Dougiamas added a comment -

          Yay Atto!

          Show
          Martin Dougiamas added a comment - Yay Atto!
          Hide
          Damyon Wiese added a comment -

          I repushed the branch with:

          The unused globals removed - I squashed this into the main commit.

          A fix for some dodgy bootstrap styles that were affecting the div for this editor. I could not actually trace them because ie dev tools don't let you inspect a generated page element and it only affects ie. Instead I set them explicitly on the div based on the values from the text area. This makes sense anyway - themers style the plain text area and the styles will affect the content editable div.

          A fix for the headings menu not appearing in the right place. This was due to a bug in M.core.dialogue.

          It's also rebased on integration.

          Show
          Damyon Wiese added a comment - I repushed the branch with: The unused globals removed - I squashed this into the main commit. A fix for some dodgy bootstrap styles that were affecting the div for this editor. I could not actually trace them because ie dev tools don't let you inspect a generated page element and it only affects ie. Instead I set them explicitly on the div based on the values from the text area. This makes sense anyway - themers style the plain text area and the styles will affect the content editable div. A fix for the headings menu not appearing in the right place. This was due to a bug in M.core.dialogue. It's also rebased on integration.
          Hide
          Damyon Wiese added a comment -

          And repushed without the extra webvi editor (oops - sorry)

          Show
          Damyon Wiese added a comment - And repushed without the extra webvi editor (oops - sorry)
          Hide
          Dan Poltawski added a comment -

          Thanks Damyon - integrated to master

          Show
          Dan Poltawski added a comment - Thanks Damyon - integrated to master
          Hide
          Dan Poltawski added a comment -

          Should we enable atto by default?

          Show
          Dan Poltawski added a comment - Should we enable atto by default?
          Hide
          Damyon Wiese added a comment -

          Hmm - it will be for new installs - but maybe we should add upgrade code.

          Show
          Damyon Wiese added a comment - Hmm - it will be for new installs - but maybe we should add upgrade code.
          Hide
          Damyon Wiese added a comment -

          For Dan,

          I have just pushed a branch with 2 fixes on it.

          Fix 1 is to enable atto by default on upgrades.
          Fix 2 is for a display issue on firefox (that I had fixed before but had lost that commit on this branch).

          The branch is MDL-41098-master-fix1 - can you pull this in Dan? Feel free to tell me to add the upgrade code in a new issue.

          Thanks

          Show
          Damyon Wiese added a comment - For Dan, I have just pushed a branch with 2 fixes on it. Fix 1 is to enable atto by default on upgrades. Fix 2 is for a display issue on firefox (that I had fixed before but had lost that commit on this branch). The branch is MDL-41098 -master-fix1 - can you pull this in Dan? Feel free to tell me to add the upgrade code in a new issue. Thanks
          Hide
          Dan Poltawski added a comment -

          Thanks Damyon, i've integrated that.

          Show
          Dan Poltawski added a comment - Thanks Damyon, i've integrated that.
          Hide
          Rajesh Taneja added a comment -

          Thanks for fixing this Damyon,

          In addition to linked subtask, problem I found were:

          1. Border style added to blockquote in Firefox and IE
          2. To add block in ie, user needs to select text, else it doesn't work.
          3. In ie, blockquotes with number or bullet option doesn't behave similar to other browsers

          Rest all look great, thanks for working on this.

          Passing this and will open another issue.

          Show
          Rajesh Taneja added a comment - Thanks for fixing this Damyon, In addition to linked subtask, problem I found were: Border style added to blockquote in Firefox and IE To add block in ie, user needs to select text, else it doesn't work. In ie, blockquotes with number or bullet option doesn't behave similar to other browsers Rest all look great, thanks for working on this. Passing this and will open another issue.
          Hide
          Rajesh Taneja added a comment -

          In addition to above, it might be nice to consider fixing keyboard navigation. Tabbing from previous field to Atto takes user though each icon.
          Also, title menu stays open, even if user focus/click on any other part of moodle. Seems like we can auto close on focus change.

          Show
          Rajesh Taneja added a comment - In addition to above, it might be nice to consider fixing keyboard navigation. Tabbing from previous field to Atto takes user though each icon. Also, title menu stays open, even if user focus/click on any other part of moodle. Seems like we can auto close on focus change.
          Hide
          Damyon Wiese added a comment -

          There was a young man named McGee
          Who thought squashing bugs was easy
          He tried it one day
          And to his dismay
          The bug guts made his keyboard all greasy

          Thanks!

          This has issue has been fixed and released in Moodle.

          Show
          Damyon Wiese added a comment - There was a young man named McGee Who thought squashing bugs was easy He tried it one day And to his dismay The bug guts made his keyboard all greasy Thanks! This has issue has been fixed and released in Moodle.
          Hide
          Mary Cooch added a comment -

          QA test added here https://tracker.moodle.org/browse/MDLQA-5730 ready for cloning into 2.6 testing next week.

          Show
          Mary Cooch added a comment - QA test added here https://tracker.moodle.org/browse/MDLQA-5730 ready for cloning into 2.6 testing next week.
          Hide
          Martin Dougiamas added a comment -

          Just a note that I've decided we need to pull this back out from 2.6, much as I love the editor and Damo.

          I think adding it as a second core alternative would:

          • confuse users with two things that are quite similar, yet different.
          • create more workload for FRONTEND to maintain it because people WILL be filing bugs for it.
          • create more ongoing workload for authors of plugin editors.
          • mess with training and documentation all over the place

          We need to revisit this again in 2.7 in the context of a complete replacement/upgrade of TinyMCE3.

          Show
          Martin Dougiamas added a comment - Just a note that I've decided we need to pull this back out from 2.6, much as I love the editor and Damo. I think adding it as a second core alternative would: confuse users with two things that are quite similar, yet different. create more workload for FRONTEND to maintain it because people WILL be filing bugs for it. create more ongoing workload for authors of plugin editors. mess with training and documentation all over the place We need to revisit this again in 2.7 in the context of a complete replacement/upgrade of TinyMCE3.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile