Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41122

Remote RSS block fails on a valid Atom feed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.8, 2.4.5, 2.5.1
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: RSS
    • Labels:
    • Testing Instructions:
      Hide

      1. Navigate to a test course.
      2. Add the Remote RSS Feeds block.
      3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/
      4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

      Show
      1. Navigate to a test course. 2. Add the Remote RSS Feeds block. 3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/ 4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41122_master

      Description

      Remote RSS block fails on the following URL:
      http://blog.une.edu.au/serviceannounce/feed/

      Error message:
      "Error loading this RSS feed (This XML document is invalid, likely due to invalid characters. XML error: Reserved XML Name at line 2, column 38)"

      The URL is deemed valid by the validator:
      http://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fblog.une.edu.au%2Fserviceannounce%2Ffeed%2F

      Investigation is showing that this is happening because the RSS body sent to Simplepie after extraction of headers begins with an empty line.

      Solution: trim() the RSS body before sending to Simplepie.

      TEST INSTRUCTIONS:
      ==================
      1. Navigate to a test course.
      2. Add the Remote RSS Feeds block.
      3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/
      4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Kirill, i'm attaching a copy of the current output of that feed so that it can be used for testing (in case that feed goes away)

              I haven't tested it though.

              Show
              poltawski Dan Poltawski added a comment - Thanks Kirill, i'm attaching a copy of the current output of that feed so that it can be used for testing (in case that feed goes away) I haven't tested it though.
              Hide
              badblock Kirill Astashov added a comment - - edited

              Added 2.3, 2.4, 2.5 and master diff and pull URLs.

              Show
              badblock Kirill Astashov added a comment - - edited Added 2.3, 2.4, 2.5 and master diff and pull URLs.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for the perfect testing instructions and patch Kirill, looks perfect and i'm sending it for integration.

              Show
              poltawski Dan Poltawski added a comment - Thanks for the perfect testing instructions and patch Kirill, looks perfect and i'm sending it for integration.
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Kirill - looks good to me.

              Integrated to 24, 25 and master.

              I tested on master and it fails on that feed url without the patch and passes with it.

              Show
              damyon Damyon Wiese added a comment - Thanks Kirill - looks good to me. Integrated to 24, 25 and master. I tested on master and it fails on that feed url without the patch and passes with it.
              Hide
              markn Mark Nelson added a comment -

              Works as expected, passing. Thanks for your contribution to Moodle, Kirill.

              Show
              markn Mark Nelson added a comment - Works as expected, passing. Thanks for your contribution to Moodle, Kirill.
              Hide
              damyon Damyon Wiese added a comment -

              Thanks for your efforts. This issue is one of the outstanding issues that passed all our testing and was accepted into Moodle this week.

              Hurray!

              Show
              damyon Damyon Wiese added a comment - Thanks for your efforts. This issue is one of the outstanding issues that passed all our testing and was accepted into Moodle this week. Hurray!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13