Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41122

Remote RSS block fails on a valid Atom feed

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3.8, 2.4.5, 2.5.1
    • 2.4.6, 2.5.2
    • RSS
    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • MDL-41122_master
    • Hide

      1. Navigate to a test course.
      2. Add the Remote RSS Feeds block.
      3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/
      4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

      Show
      1. Navigate to a test course. 2. Add the Remote RSS Feeds block. 3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/ 4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

    Description

      Remote RSS block fails on the following URL:
      http://blog.une.edu.au/serviceannounce/feed/

      Error message:
      "Error loading this RSS feed (This XML document is invalid, likely due to invalid characters. XML error: Reserved XML Name at line 2, column 38)"

      The URL is deemed valid by the validator:
      http://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fblog.une.edu.au%2Fserviceannounce%2Ffeed%2F

      Investigation is showing that this is happening because the RSS body sent to Simplepie after extraction of headers begins with an empty line.

      Solution: trim() the RSS body before sending to Simplepie.

      TEST INSTRUCTIONS:
      ==================
      1. Navigate to a test course.
      2. Add the Remote RSS Feeds block.
      3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/
      4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

      Attachments

        Issue Links

          Activity

            People

              badblock Kirill Astashov
              badblock Kirill Astashov
              Dan Poltawski Dan Poltawski
              Damyon Wiese Damyon Wiese
              Mark Nelson Mark Nelson
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13