Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41122

Remote RSS block fails on a valid Atom feed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.8, 2.4.5, 2.5.1
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: RSS
    • Labels:
    • Testing Instructions:
      Hide

      1. Navigate to a test course.
      2. Add the Remote RSS Feeds block.
      3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/
      4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

      Show
      1. Navigate to a test course. 2. Add the Remote RSS Feeds block. 3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/ 4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41122_master

      Description

      Remote RSS block fails on the following URL:
      http://blog.une.edu.au/serviceannounce/feed/

      Error message:
      "Error loading this RSS feed (This XML document is invalid, likely due to invalid characters. XML error: Reserved XML Name at line 2, column 38)"

      The URL is deemed valid by the validator:
      http://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fblog.une.edu.au%2Fserviceannounce%2Ffeed%2F

      Investigation is showing that this is happening because the RSS body sent to Simplepie after extraction of headers begins with an empty line.

      Solution: trim() the RSS body before sending to Simplepie.

      TEST INSTRUCTIONS:
      ==================
      1. Navigate to a test course.
      2. Add the Remote RSS Feeds block.
      3. Configure the block with the following URL: http://blog.une.edu.au/serviceannounce/feed/
      4. Upon save, the block should add the URL successfully and not issue an "Error loading this RSS feed" message.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                badblock Kirill Astashov
                Reporter:
                badblock Kirill Astashov
                Peer reviewer:
                Dan Poltawski
                Integrator:
                Damyon Wiese
                Tester:
                Mark Nelson
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/13