[MDL-41131] Allow assignment plugins to "just be on" - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6
Fix Version/s: 2.6
Component/s: Assignment
Labels:
- triaged
- ui_change

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Epic Link:
Add Upload PDF to core
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Master Branch:
~~MDL-41131~~_c
Pull Master Diff URL:
https://github.com/rwijaya/moodle/compare/moodle:master...MDL-41131_c
Testing Instructions:
Hide

Make sure "Annotate PDF' is installed and not hidden.

Go to site admin > plugins > assignment plugins > manage assignment plugins and make sure the setting link for submission comments is no longer available.

Enable comments in advanced features.

Purge all caches

Create assignment activities and notice you don't see 'submission comments'.

Make sure assignfeedback_editpdf_enabled setting is set as hidden input.

Disable comments in advanced features.

Purge all caches

Create assignment activities and notice you don't see 'submission comments'.

Run unittest for assignment.
Show
Make sure "Annotate PDF' is installed and not hidden. Go to site admin > plugins > assignment plugins > manage assignment plugins and make sure the setting link for submission comments is no longer available. Enable comments in advanced features. Purge all caches Create assignment activities and notice you don't see 'submission comments'. Make sure assignfeedback_editpdf_enabled setting is set as hidden input. Disable comments in advanced features. Purge all caches Create assignment activities and notice you don't see 'submission comments'. Run unittest for assignment.

Story Points:
8
Sprint:
FRONTEND Sprint 5

Description

ie - if the assignment plugin says - I AM ON - don't make the user tick the checkbox.

Apply this to submission_comments if comments are enabled, and to feedback_pdf.

Attachments

Issue Links

caused a regression

MDL-42433 No longer able to annotate pdfs in 2.6 beta

Closed

has been marked as being related by

MDL-55625 Comments can be added to submission after cut-off date

Open

Activity

People

Assignee:: Rossiani Wijaya

Reporter:: Damyon Wiese

Peer reviewer:: Damyon Wiese

Integrator:: Dan Poltawski

Tester:: Jérôme Mouneyrac

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Jérôme Mouneyrac, Mary Cooch, Rossiani Wijaya

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 12/Aug/13 1:20 PM

Updated:: 19/Aug/16 7:01 AM

Resolved:: 18/Oct/13 5:56 PM

Fix Release Date:: 18/Nov/13