Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.6
-
Fix Version/s: 2.6
-
Component/s: Backup
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_26_STABLE
-
Fixed Branches:MOODLE_26_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-41146-master -
Pull Master Diff URL:
Description
The backup_includes_files function is called repeatedly during backup. For a typical backup that contains a large number of files, it could be called many times.
This function works by loading a backup controller, calling one function in it, and then discarding it.
This behaviour can cause a memory leak - in my testing, I found that even with 4GB memory limit, it ran out while backing up my 'L' test course - but also seems unnecessary from a performance perspective.
I am investigating possible solutions and will submit a fix shortly.
Attachments
Issue Links
- is a regression caused by
-
MDL-37761 Improve backup/restore within Moodle (e.g. course and activity duplication)
-
- Closed
-