Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38189 META Backup/restore issues with large courses
  3. MDL-41167

Large course restore times out on Review page

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.6
    • 2.6
    • Backup
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-41167-master
    • Hide

      1. If you don't have one already, create the 'M' size test course using MDL-38197, and make a backup of it using default settings. (Note: We are using the 'M' backup because it will restore without hitting limits that mean you need a million other bugfixes to make it work, but still takes long enough to show a progress bar.)

      2. Restore the backup. Continue through the restore screens, selecting to restore to a new course, until you get to the Review screen.

      EXPECTED: While displaying the review screen, a progress bar will briefly appear and move across.

      NOTE: This might not be a very high proportion of the time, depending on whether other changes like MDL-41163 have been committed or not.

      NOTE: I'm a bit concerned about the timing - if your server is faster than mine, the progress bar might not display at all, because it only appears if it takes more than five seconds for a certain stage. Not sure what to do about this though, hopefully it will work.

      EXPECTED: The progress bar will then disappear, leaving the normal review screen as before.

      3. Continue past the review screen to restore the course.

      EXPECTED: Restore completes successfully.

      Show
      1. If you don't have one already, create the 'M' size test course using MDL-38197 , and make a backup of it using default settings. (Note: We are using the 'M' backup because it will restore without hitting limits that mean you need a million other bugfixes to make it work, but still takes long enough to show a progress bar.) 2. Restore the backup. Continue through the restore screens, selecting to restore to a new course, until you get to the Review screen. EXPECTED: While displaying the review screen, a progress bar will briefly appear and move across. NOTE: This might not be a very high proportion of the time, depending on whether other changes like MDL-41163 have been committed or not. NOTE: I'm a bit concerned about the timing - if your server is faster than mine, the progress bar might not display at all, because it only appears if it takes more than five seconds for a certain stage. Not sure what to do about this though, hopefully it will work. EXPECTED: The progress bar will then disappear, leaving the normal review screen as before. 3. Continue past the review screen to restore the course. EXPECTED: Restore completes successfully.

    Description

      After fixes to other issues, there is still a problem with a timeout on the Review page with a large backup.

      Stack trace:

      [13-Aug-2013 15:37:45 Europe/London] PHP Fatal error:  Maximum execution time of 120 seconds exceeded in /fs1/www_root/sm449/coremoodle/cache/classes/loaders.php on line 517
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP Stack trace:
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   1. {main}() /fs1/www_root/sm449/coremoodle/backup/restore.php:0
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   2. restore_ui->requires_substage() /fs1/www_root/sm449/coremoodle/backup/restore.php:65
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   3. restore_ui_stage_process->process() /fs1/www_root/sm449/coremoodle/backup/util/ui/restore_ui.class.php:284
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   4. restore_controller->execute_precheck() /fs1/www_root/sm449/coremoodle/backup/util/ui/restore_ui_stage.class.php:703
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   5. restore_prechecks_helper::execute_prechecks() /fs1/www_root/sm449/coremoodle/backup/controller/restore_controller.class.php:366
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   6. restore_dbops::precheck_included_users() /fs1/www_root/sm449/coremoodle/backup/util/helper/restore_prechecks_helper.class.php:119
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   7. restore_dbops::precheck_user() /fs1/www_root/sm449/coremoodle/backup/util/dbops/restore_dbops.class.php:1430
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   8. moodle_database->get_record() /fs1/www_root/sm449/coremoodle/backup/util/dbops/restore_dbops.class.php:1220
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP   9. moodle_database->where_clause() /fs1/www_root/sm449/coremoodle/lib/dml/moodle_database.php:1360
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP  10. pgsql_native_moodle_database->get_columns() /fs1/www_root/sm449/coremoodle/lib/dml/moodle_database.php:564
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP  11. cache_application->get() /fs1/www_root/sm449/coremoodle/lib/dml/pgsql_native_moodle_database.php:390
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP  12. cache->get() /fs1/www_root/sm449/coremoodle/cache/classes/loaders.php:1350
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP  13. cache->unref() /fs1/www_root/sm449/coremoodle/cache/classes/loaders.php:290
      		 
      [13-Aug-2013 15:37:45 Europe/London] PHP  14. serialize() /fs1/www_root/sm449/coremoodle/cache/classes/loaders.php:517

      Attachments

        Issue Links

          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-41253 Restore: Need a way to display progress during UI stages

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              quen Sam Marshall
              quen Sam Marshall
              Dan Poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Marina Glancy Marina Glancy
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13