Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.6
-
Fix Version/s: 2.6
-
Component/s: Course
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_26_STABLE
-
Fixed Branches:MOODLE_26_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-41181-master -
Pull Master Diff URL:
Description
At the moment function moveto_module($mod, $section, $beforemod=NULL) may modify the value of $mod->visible . It is only needed for /course/reset.php to serve AJAX requests to move the module.
First argument may be an instance of cm_info. In MDL-34397 I'm making all properties of cm_info read-only and this function is the only problem.
Instead moveto_module may return the new value for module visibility.
Also to mention that modifying JUST $mod->visible is not correct anyway. Other properties such as $mod->uservisible may be affected by this change as well.