[MDL-41192] Performance and usability improvements in class cm_info - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.6
Fix Version/s: 2.6
Component/s: Course
Labels:
- triaged

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Epic Link:
Course caching
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-~~MDL-41192~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/wip-MDL-41218-master...wip-MDL-41192-master
Testing Instructions:
Hide

Must be no regressions and performance improvement in the following cases:

Enable completion and conditional availability (otherwise there are no extra queries and therefore no performance improvements)

Make course display one section per page

If section A has activities with conditional availability and user views section B, the availability of unshown activities is not calculated.

Same with viewing /my/ page - you should see the performance improvement, especially if MAX_MODINFO_CACHE_SIZE is less than number of courses displayed on the page.

Same with overview pages mod/xxxx/index.php
Show
Must be no regressions and performance improvement in the following cases: Enable completion and conditional availability (otherwise there are no extra queries and therefore no performance improvements) Make course display one section per page If section A has activities with conditional availability and user views section B, the availability of unshown activities is not calculated. Same with viewing /my/ page - you should see the performance improvement, especially if MAX_MODINFO_CACHE_SIZE is less than number of courses displayed on the page. Same with overview pages mod/xxxx/index.php

Sprint:
BACKEND Sprint 4

Description

Classes cm_info should not perform any calculations/requests in constructor, all properties should be read-only and those that need calculations have getters methods so they are calculated on the first request only.

What it saves: when we call get_fast_modinfo() for the whole course but only actually need one activity (or only activities in one sections, activities of particular type, etc.), the other activities' visibility is not calculated. At the moment it can be expensive if conditions or groups are used.

Attachments

Issue Links

blocks

MDL-41219 Usability improvements in class course_modinfo

Closed

caused a regression

MDL-46280 Activity auto linking filter breaks when similar activity names are used

Closed

MDL-42441 DnD: It is not allowed to set the property cm_info::$<property>

Closed

MDL-42463 mod_chat attempts to access $cm->lasttime

Closed

MDL-42534 cm_info $cache issues when viewing someone's posts

Closed

has a non-specific relationship to

MDL-41690 Deprecate previously public methods in class cm_info

Closed

is blocked by

MDL-36690 invalid iconurl in LTI module causes corrupt modinfo and course no longer loads.

Closed

MDL-41179 Function cm_info::is_user_access_restricted_by_capability() assumes current user

Closed

MDL-41181 moveto_module() should not modify arguments

Closed

(1 has a non-specific relationship to, 3 is blocked by)

Activity

People

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Rajesh Taneja

Integrator:: Sam Hemelryk

Tester:: Rossiani Wijaya

Participants:: Damyon Wiese, Marina Glancy, Rajesh Taneja, Rossiani Wijaya, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 14/Aug/13 5:39 PM

Updated:: 08/Jul/14 5:49 PM

Resolved:: 13/Sep/13 3:44 PM

Fix Release Date:: 18/Nov/13