[MDL-41197] core_text::convert produces notices when experiencing invalid utf8 params or char not in target encoding - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.4.6, 2.5.2, 2.6
Fix Version/s: 2.4.7, 2.5.3
Component/s: Libraries
Labels:
- triaged

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull Master Branch:
w41_~~MDL-41197~~_m26_convnotices
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w41_MDL-41197_m26_convnotices
Testing Instructions:

Hide

Run unit tests

Show
Run unit tests

Story Points:
2
Sprint:
BACKEND Sprint 5

Description

It is missing the silence param.

Here is a phpunit assertion to demonstrate the problem:
https://github.com/danpoltawski/moodle/commit/e6483931cfc507f4997f815fdb420a52121630a2

Here is a quick fix https://github.com/danpoltawski/moodle/commit/d6378ddcc0e6e248f92b65f520c8f77a85298ffb

Attachments

Issue Links

blocks

MDL-42054 phpmailer unit test redirection is using incorrect test

Closed

MDL-41258 Add additional unit tests to test mod_forum cron

Closed

Testing discovered

MDL-4908 Per-forum digest settings

Closed

MDL-41258 Add additional unit tests to test mod_forum cron

Closed

Activity

People

Assignee:: Petr Skoda

Reporter:: Dan Poltawski

Peer reviewer:: Ankit Agarwal

Integrator:: Sam Hemelryk

Tester:: Sam Hemelryk

Participants:: Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Petr Skoda, Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 15/Aug/13 12:15 AM

Updated:: 11/Oct/13 10:11 PM

Resolved:: 11/Oct/13 10:11 PM

Fix Release Date:: 11/Nov/13