Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41213

File picker modal layout issues when using clean theme.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as a student
      2. Navigate to a course
      3. Click the assignment
      4. Within the file manager area, select a file (to edit), if there's no file available within the filemanager, you need to add it by selecting 'add..' button.
      5. When clicking on the image ensure there is no dotted line, there is spacing between the label and input field and the ':' is not on a new line. (see screenshot)
      6. Check that the set license select box is sized appropriately.

      Test standard and clean on 25 and master. standard only for 2.4.
      The colon and license select box issues only exist on clean.

      Show
      Login as a student Navigate to a course Click the assignment Within the file manager area, select a file (to edit), if there's no file available within the filemanager, you need to add it by selecting 'add..' button. When clicking on the image ensure there is no dotted line, there is spacing between the label and input field and the ':' is not on a new line. (see screenshot) Check that the set license select box is sized appropriately. Test standard and clean on 25 and master. standard only for 2.4. The colon and license select box issues only exist on clean.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      41213-26
    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 4

      Description

      1. Log in as any user.
      2. Visit 'My Profile' -> 'My Private Files'.
      3. Click to add a file.
      4. Search for a picture in wikimedia.
      5. Click to open it.
      6. Notice the following issues -

      Dotted line appears (in master due to MDL-39851), colon appears on the line below 'Choose license', there is no spacing between the label and select box and the select box extends out of the window. See the screenshot attached for demonstration of this.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Damyon Wiese
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13