Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41216

Recast SCORM style.css in block style

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.7
          • Fix Version/s: 2.7
          • Component/s: SCORM
          • Labels:
          • Testing Instructions:
            Hide

            This is a change to whitespace in the code only - no actual UI changes should occur.

            it should be sufficient to open a scorm and make sure it displays the same way it did before the patch.

            Show
            This is a change to whitespace in the code only - no actual UI changes should occur. it should be sufficient to open a scorm and make sure it displays the same way it did before the patch.
          • Affected Branches:
            MOODLE_27_STABLE
          • Fixed Branches:
            MOODLE_27_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            The mod/scorm/style.css is to be rewritten as per block style CSS coding style mentioned here
            http://docs.moodle.org/dev/CSS_coding_style#Block_Style

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is blocked by

                  Improvement - An enhancement to an existing Moodle feature. MDL-39910 SCORM player improvements

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    danmarsden Dan Marsden added a comment -

                    just did this as part of the work I'm doing in MDL-41290

                    Show
                    danmarsden Dan Marsden added a comment - just did this as part of the work I'm doing in MDL-41290
                    Hide
                    Permalink
                    danmarsden Dan Marsden added a comment -

                    MDL-41290 must be integrated before this patch.

                    Show
                    danmarsden Dan Marsden added a comment - MDL-41290 must be integrated before this patch.
                    Hide
                    Permalink
                    danmarsden Dan Marsden added a comment -

                    this will conflict - re-opening until next week after MDL-39910 is sorted.

                    Show
                    danmarsden Dan Marsden added a comment - this will conflict - re-opening until next week after MDL-39910 is sorted.
                    Hide
                    Permalink
                    cibot CiBoT added a comment -

                    Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

                    Show
                    cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
                    Hide
                    Permalink
                    nobelium vignesh p added a comment -

                    Hi Dan, I saw your branch n its kinda obsolete. I have edited style.css on my repository. https://github.com/nobelium/moodle/compare/MDL-41216. If everything is ok please merge it.

                    Show
                    nobelium vignesh p added a comment - Hi Dan, I saw your branch n its kinda obsolete. I have edited style.css on my repository. https://github.com/nobelium/moodle/compare/MDL-41216 . If everything is ok please merge it.
                    Hide
                    Permalink
                    cibot CiBoT added a comment -

                    Results for MDL-41216

                    Show
                    cibot CiBoT added a comment - Results for MDL-41216 Remote repository: https://github.com/nobelium/moodle.git Remote branch MDL-41216 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2300 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2300/artifact/work/smurf.html
                    Hide
                    Permalink
                    danmarsden Dan Marsden added a comment -

                    thanks Vignesh - looks good to me.

                    Show
                    danmarsden Dan Marsden added a comment - thanks Vignesh - looks good to me.
                    Hide
                    Permalink
                    cibot CiBoT added a comment -

                    Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

                    Show
                    cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
                    Hide
                    Permalink
                    cibot CiBoT added a comment -

                    Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

                    Show
                    cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Integrated (master), thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (master), thanks!
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    I've tried a simple SCORM and also have compared the before/after css with recess and both are 100% the same.

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - I've tried a simple SCORM and also have compared the before/after css with recess and both are 100% the same.
                    Hide
                    Permalink
                    marina Marina Glancy added a comment -

                    Thanks for your awesome code, it is now part of Moodle. Don't forget to submit another issue next week (and peer review two).

                    Show
                    marina Marina Glancy added a comment - Thanks for your awesome code, it is now part of Moodle. Don't forget to submit another issue next week (and peer review two).

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        5 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          12/May/14