Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41218

Performance and usability improvements in class section_info

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Must be no regressions and performance improvement in the following cases:

      1. Enable completion and conditional availability (otherwise there are no extra queries and therefore no performance improvements)
      2. Add conditional availability to some course sections
      3. Make course display one section per page
      4. If section A has conditional availability and user views section B, the availability of unshown section is not calculated.
      5. Same with viewing /my/ page - you should see the performance improvement, especially if MAX_MODINFO_CACHE_SIZE is less than number of courses displayed on the page.
      6. Same with overview pages mod/xxxx/index.php. For example, if section X has conditional availability but contains no instances of module xxxx, this section's availability is not calculated while displaying mod/xxxx/index.php
      Show
      Must be no regressions and performance improvement in the following cases: Enable completion and conditional availability (otherwise there are no extra queries and therefore no performance improvements) Add conditional availability to some course sections Make course display one section per page If section A has conditional availability and user views section B, the availability of unshown section is not calculated. Same with viewing /my/ page - you should see the performance improvement, especially if MAX_MODINFO_CACHE_SIZE is less than number of courses displayed on the page. Same with overview pages mod/xxxx/index.php. For example, if section X has conditional availability but contains no instances of module xxxx, this section's availability is not calculated while displaying mod/xxxx/index.php
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Epic Link:
    • Pull Master Branch:
      wip-MDL-41218-master
    • Sprint:
      BACKEND Sprint 4

      Description

      • Calculate uservisible, available, availabe_info on demand only
      • Proper phpdocs for properties and methods
      • Do not store unnecessary data

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Rajesh Taneja Rajesh Taneja
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Rossiani Wijaya Rossiani Wijaya
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13