Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41231

Export to portfolio button at bottom of database activity view doesn't work if Delete selected button is displayed.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable portfolios
        • Go to [Administration ► Site administration ► Advanced features] and tick "Enable portfolios"
        • Go to [Administration ► Site administration ► Plugins ► Portfolios ► Manage portfolios] And enable a portfolio. I enabled Box.net (as this doesn't require too much messing around to get working).
      2. Create a database activity.
        • Make sure to add a few fields.
        • When you look at the list view, ensure that there are buttons at the bottom for selecting and deleting records as well as one for exporting to a portfolio.
      3. Try selecting a couple of records and then clicking the "delete selected" button. This button should take you to a page confirming that you want to delete the records. Hit confirm or cancel depending on how you feel. [Test One]
      4. Now try clicking the "export to portfolio button" (make sure you still have records to export) and make sure that it takes you to an new page to export your portfolio. [Test Two]
      Show
      Enable portfolios Go to [Administration ► Site administration ► Advanced features] and tick "Enable portfolios" Go to [Administration ► Site administration ► Plugins ► Portfolios ► Manage portfolios] And enable a portfolio. I enabled Box.net (as this doesn't require too much messing around to get working). Create a database activity. Make sure to add a few fields. When you look at the list view, ensure that there are buttons at the bottom for selecting and deleting records as well as one for exporting to a portfolio. Try selecting a couple of records and then clicking the "delete selected" button. This button should take you to a page confirming that you want to delete the records. Hit confirm or cancel depending on how you feel. [Test One] Now try clicking the "export to portfolio button" (make sure you still have records to export) and make sure that it takes you to an new page to export your portfolio. [Test Two]
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-41231-master
    • Story Points:
      4
    • Sprint:
      BACKEND Sprint 4

      Description

      The new Delete selected button overrides the Export to portfolio button. This means that the Delete selected button doesn't do anything and the Export to portfolio button now tries to delete selected entries.

      This is due to the fact that each of these sections can be enabled and disabled and generate a closing form tag, which when both are active causes a problem.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Damyon Wiese
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13