Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5.1
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide
      • On a test server without the patch:
        • Attempt to restore attached backup MDL-41254-1.mbz on a server with PHP max_execution_time set to 30 seconds
        • Ensure that you see the maximum script execution time exceeded error. If backup restores successfully, lower max_execution_time and repeat until it fails
      • Apply the patch
        • Restore the backup file and confirm that it restores successfully without timing out
      Show
      On a test server without the patch: Attempt to restore attached backup MDL-41254 -1.mbz on a server with PHP max_execution_time set to 30 seconds Ensure that you see the maximum script execution time exceeded error. If backup restores successfully, lower max_execution_time and repeat until it fails Apply the patch Restore the backup file and confirm that it restores successfully without timing out
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      When restoring the L test course, the restore times out during the precheck stage, before it gets to the point of displaying the restore progress bar.

      Fatal error: Maximum execution time of 120 seconds exceeded in /fs1/www_root/sm449/coremoodle/lib/dml/moodle_database.php on line 783
       
      Call Stack:
          0.0005     638904   1. {main}() /fs1/www_root/sm449/coremoodle/backup/restore.php:0
         36.5749  131225240   2. restore_ui->requires_substage() /fs1/www_root/sm449/coremoodle/backup/restore.php:74
         36.5749  131226680   3. restore_ui_stage_process->process() /fs1/www_root/sm449/coremoodle/backup/util/ui/restore_ui.class.php:321
         37.9044  116754160   4. restore_controller->execute_precheck() /fs1/www_root/sm449/coremoodle/backup/util/ui/restore_ui_stage.class.php:710
         37.9044  116755616   5. restore_prechecks_helper::execute_prechecks() /fs1/www_root/sm449/coremoodle/backup/controller/restore_controller.class.php:366
         82.5110  152411816   6. restore_dbops::load_users_to_tempids() /fs1/www_root/sm449/coremoodle/backup/util/helper/restore_prechecks_helper.class.php:118
         82.5113  152430544   7. progressive_parser->process() /fs1/www_root/sm449/coremoodle/backup/util/dbops/restore_dbops.class.php:414
        205.9347  152564920   8. progressive_parser->parse() /fs1/www_root/sm449/coremoodle/backup/util/xml/parser/progressive_parser.class.php:137
        205.9347  152565000   9. xml_parse() /fs1/www_root/sm449/coremoodle/backup/util/xml/parser/progressive_parser.class.php:158
        205.9400  152553224  10. progressive_parser->end_tag() /fs1/www_root/sm449/coremoodle/backup/util/xml/parser/progressive_parser.class.php:158
        205.9400  152553232  11. progressive_parser->inform_end() /fs1/www_root/sm449/coremoodle/backup/util/xml/parser/progressive_parser.class.php:263
        205.9400  152553296  12. grouped_parser_processor->after_path() /fs1/www_root/sm449/coremoodle/backup/util/xml/parser/progressive_parser.class.php:183
        205.9400  152553264  13. restore_users_parser_processor->dispatch_chunk() /fs1/www_root/sm449/coremoodle/backup/util/xml/parser/processors/grouped_parser_processor.class.php:123
        205.9463  152555184  14. restore_dbops::set_backup_ids_record() /fs1/www_root/sm449/coremoodle/backup/util/helper/restore_users_parser_processor.class.php:65
        205.9465  152556544  15. restore_dbops::set_backup_ids_cached() /fs1/www_root/sm449/coremoodle/backup/util/dbops/restore_dbops.class.php:1518
        205.9465  152557352  16. moodle_database->get_record() /fs1/www_root/sm449/coremoodle/backup/util/dbops/restore_dbops.class.php:257
        205.9471  152558136  17. moodle_database->get_record_select() /fs1/www_root/sm449/coremoodle/lib/dml/moodle_database.php:1361
        205.9471  152558464  18. moodle_database->get_record_sql() /fs1/www_root/sm449/coremoodle/lib/dml/moodle_database.php:1382
        205.9471  152558680  19. pgsql_native_moodle_database->get_records_sql() /fs1/www_root/sm449/coremoodle/lib/dml/moodle_database.php:1410
        205.9471  152558832  20. moodle_database->fix_sql_params() /fs1/www_root/sm449/coremoodle/lib/dml/pgsql_native_moodle_database.php:741
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  5 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Nov/13