Moodle
  1. Moodle
  2. MDL-41267

Add support for admin tool subplugins

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Logging
    • Labels:
    • Story Points:
      5
    • Rank:
      51956
    • Sprint:
      BACKEND Sprint 4

      Description

      This was requested a few times already, since 2.6 this does not have any significant performance cost. It could help other tools too.

      The only potential problem is that admin tools are in $CFG->dirroot/$CFG->admin/tool, we need to deal with alternative $CFG->admin !== 'admin'

        Issue Links

          Activity

          Hide
          Jason Fowler added a comment -

          Code looks good, makes sense. Pushing for integration for you now Petr.

          Show
          Jason Fowler added a comment - Code looks good, makes sense. Pushing for integration for you now Petr.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          test_get_plugin_types_with_subplugins() ? NVM, adding it.

          Show
          Eloy Lafuente (stronk7) added a comment - test_get_plugin_types_with_subplugins() ? NVM, adding it.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Jérôme Mouneyrac added a comment -

          Tested with petr tool. Passed.

          Show
          Jérôme Mouneyrac added a comment - Tested with petr tool. Passed.
          Hide
          Dan Poltawski added a comment -

          Congratulations! This change has been integrated upstream and is now available from our git and download mirrors. To celebrate, here is a joke:

          A SQL query goes into a bar, walks up to two tables and asks, "Can I join you?"

          Show
          Dan Poltawski added a comment - Congratulations! This change has been integrated upstream and is now available from our git and download mirrors. To celebrate, here is a joke: A SQL query goes into a bar, walks up to two tables and asks, "Can I join you?"

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile