Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41291

don't use filesize when reading from cache_filestore


    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.4.6, 2.5.2
    • 2.4.5, 2.5
    • Caching
    • None

      cache_filestore has a hack, suggesting that PHPUnit tests fail, but normal operation is correct.

      My estimation of the situation is that under PHPUnit, clearstatcache() wasn't called at some point, which required the guess of the larger size. The current PHPUnit tests pass without the hack.

      However all this exposes the issue of race conditions and caching between what the filesize is and what's actually read. To remove that, we will not just use fread to collect all the data until the end of file is reached.

            mr-russ Russell Smith
            mr-russ Russell Smith
            Sam Hemelryk Sam Hemelryk
            Dan Poltawski Dan Poltawski
            Jason Fowler Jason Fowler
            1 Vote for this issue
            5 Start watching this issue


                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.