Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41291

don't use filesize when reading from cache_filestore

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4.5, 2.5
    • 2.4.6, 2.5.2
    • Caching
    • None

    Description

      cache_filestore has a hack, suggesting that PHPUnit tests fail, but normal operation is correct.

      My estimation of the situation is that under PHPUnit, clearstatcache() wasn't called at some point, which required the guess of the larger size. The current PHPUnit tests pass without the hack.

      However all this exposes the issue of race conditions and caching between what the filesize is and what's actually read. To remove that, we will not just use fread to collect all the data until the end of file is reached.

      Attachments

        Issue Links

          Activity

            People

              mr-russ Russell Smith
              mr-russ Russell Smith
              Sam Hemelryk Sam Hemelryk
              Dan Poltawski Dan Poltawski
              Jason Fowler Jason Fowler
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13