Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 2.4.6, 2.5.2
Affects Version/s: 2.4.5, 2.5
Component/s: Caching
Labels:
None

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/mr-russ/moodle.git
Pull Main Branch:
~~MDL-41291~~-master
Pull Main Diff URL:
https://github.com/mr-russ/moodle/compare/master...MDL-41291-master
Testing Instructions:

Hide

1. Run PHPUnit tests.
2. Browse course pages and ensure no errors.

Show
1. Run PHPUnit tests. 2. Browse course pages and ensure no errors.

cache_filestore has a hack, suggesting that PHPUnit tests fail, but normal operation is correct.

My estimation of the situation is that under PHPUnit, clearstatcache() wasn't called at some point, which required the guess of the larger size. The current PHPUnit tests pass without the hack.

However all this exposes the issue of race conditions and caching between what the filesize is and what's actually read. To remove that, we will not just use fread to collect all the data until the end of file is reached.

has a non-specific relationship to

MDL-40841 Move all file system operations to some core_io wrapper

Closed

has been marked as being related by

MDL-41058 "filesize(): stat failed" warnings from cache when running multiple front ends

Closed

will help resolve

MDL-41084 Exception throwing in MUC cache loading causes ungraceful fallback to non-cache

Closed

Assignee:: Russell Smith

Reporter:: Russell Smith

Peer reviewer:: Sam Hemelryk

Integrator:: Dan Poltawski

Tester:: Jason Fowler

Participants:: Damyon Wiese, Dan Poltawski, Jason Fowler, Matteo Scaramuccia, Russell Smith, Sam Hemelryk

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 19/Aug/13 6:21 PM

Updated:: 30/Aug/13 10:54 AM

Resolved:: 30/Aug/13 10:54 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify