Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41292

MUC set_identifiers removes singlekeyprefix cache, even when identifiers have not changed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5, 2.6, 2.7
    • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide

      1. Run PHPUnit tests
      2. Browse course pages

      If you have XHProf installed...

      Review a profile of a course page and confirm that generate_single_key_prefix does not make function calls in the numbers that approach the number of calls being made to set_identifiers.

      Show
      1. Run PHPUnit tests 2. Browse course pages If you have XHProf installed... Review a profile of a course page and confirm that generate_single_key_prefix does not make function calls in the numbers that approach the number of calls being made to set_identifiers.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41292-master

      Description

      When set_identifiers is called, it resets singlekeyprefix. So each time cache::make factory method is called with the same set of identifiers, the cache is reset. This uses unnecessary time rebuilding the key, which is attempted to be cached.

      If the identifiers are the same as the currently set ones, they should be ignored and just return.

        Attachments

          Activity

            People

            Assignee:
            mr-russ Russell Smith
            Reporter:
            mr-russ Russell Smith
            Peer reviewer:
            Sam Hemelryk
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jan/14