Thanks for reporting that and providing patches. Feel free to put that up for peer review.

You might want to add a bit more detail to the testing instructions. Most of the devs around here have limited LDAP experience.

Hi Tim,

We tend to avoid using @ to suppress warnings with any newly introduced code, however in this case I see no other alternative. The logic seems fine to me.

Thanks for your contribution.

Regards,

Mark

Hi Mark,

Thanks and I agree that silencing errors with an @ should be avoided if possible.

Thanks Tim - i've integrated it to master, 25 and 24

Thanks for fixing this Tim,

Passing test...

Congratulations! This change has been integrated upstream and is now available from our git and download mirrors. To celebrate, here is a joke:

A SQL query goes into a bar, walks up to two tables and asks, "Can I join you?"

I hate to re-open this, but the fix is incomplete. If you configure the LDAP auth plugin not to search subcontexts, you get the same warnings (under the same circumstances). So the check for $ldap_result and the break sentence should go after the "if then else" block, before the call to ldap_first_entry(). And we would also need to silence the call to ldap_list() for the same reasons.

I'll prepare patches in a few hours and will put the links to github here.

Hi Iñaki,

Can we create a new issue for this, as reopening the issue doesn't really work with our workflow.

thanks

Sure, Dan.

Thanks, sending this back to closed. Please link it to here.