Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41311

Remove legacy tool_generator mess

    XMLWordPrintable

Details

    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-41311-master
    • Hide
      1. Use the course generator
      2. VERIFY: no errors are experienced and course generator works
      3. Use the site generator cli tool
      4. VERIFY: no errors are experienced and site is generated
      5. Go to admin/tool/generator/
      6. VERIFY: you are redirected to the make course tool
      Show
      Use the course generator VERIFY: no errors are experienced and course generator works Use the site generator cli tool VERIFY: no errors are experienced and site is generated Go to admin/tool/generator/ VERIFY: you are redirected to the make course tool

    Description

      There is some completely unmaintained code in admin/tool/generator to create test courses. Its not worked for some time and should be removed.

      In MDL-38197, Sam added a partial replacement. I don't believe we need to worry about backwards compatibility here as it was a developer tool, marked experimental and people keep trying to fix bugs in it/use it when its really not stable at all for use.

      The existing functionality should be replaced by switching to generators (as used by behat and phpunit) but I don't believe we need to wait for that because people are wasting their time trying to use it or monkeypatch it.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43081 Add upgrade.txt note about removal of tool_generator code

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42545 "generator" as class name is php5.5 incompatible

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-38197 Automated large-course generation for testing

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40608 Creating Forum Using Admin Tools 'Generator' result in an error

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30938 Call to undefined function resource_set_mainfile()

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42545 "generator" as class name is php5.5 incompatible

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              David Monllaó David Monllaó
              Marina Glancy Marina Glancy
              Petr Skoda Petr Skoda
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13