Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41312

Remove events_trigger_legacy() for groups from core

    XMLWordPrintable

Details

    • BACKEND Sprint 19, 3.1 Stable Sprint 2, 3.1 Sprint 3
    • Small

    Description

      Some events_trigger() were left for backwards compatibility because they cannot be replaced by a new event as they are wrong (bulk events).

      They should be removed during 2.7-dev for 2.8 release.

      See group/lib.php:

      • groups_delete_group_members() > groups_members_removed
      • groups_delete_groupings_groups() > groups_groupings_groups_removed
      • groups_delete_groups() > groups_groups_deleted
      • groups_delete_groupings() > groups_groupings_deleted

      $ git grep MDL-41312
      		 
      group/lib.php:    // TODO MDL-41312 Remove events_trigger_legacy('groups_members_removed').
      		 
      group/lib.php:    // TODO MDL-41312 Remove events_trigger_legacy('groups_groupings_groups_removed').
      		 
      group/lib.php:    // TODO MDL-41312 Remove events_trigger_legacy('groups_groups_deleted').
      		 
      group/lib.php:    // TODO MDL-41312 Remove events_trigger_legacy('groups_groupings_deleted').

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-53270 groups_assign_grouping and groups_unassign_grouping are not logged

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-39958 Replace Legacy events - Groups

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-45835 Trigger events when un/assigning groups to a grouping

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-48621 Deprecate the old events system

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-47779 Review TODO with associated MDL's

          • Minor - Minor loss of function where workaround is possible
          • Open

          Activity

            People

              ankit_frenz Ankit Agarwal
              fred Frédéric Massart
              Simey Lameze Simey Lameze
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/18