Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41321

Add styling to Group description table in Bootstrapbase

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:

      Description

      The description table in the header of the Group members page looks ugly with just a black border. Adding simple styling, in keeping with Bootstrap styles, looks tidier.

      See attached image.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              lazydaisy Mary Evans added a comment - - edited

              @DanP,
              Hope you can find time to peer review this before I push it for integration.?
              Many thanks in anticipation,
              Mary

              Show
              lazydaisy Mary Evans added a comment - - edited @DanP, Hope you can find time to peer review this before I push it for integration.? Many thanks in anticipation, Mary
              Hide
              lazydaisy Mary Evans added a comment -

              Found while working on MDL-41175

              Show
              lazydaisy Mary Evans added a comment - Found while working on MDL-41175
              Hide
              poltawski Dan Poltawski added a comment -

              No, I won't have any time, sorry. So i'm leaving it open for someone else to look at it.

              Show
              poltawski Dan Poltawski added a comment - No, I won't have any time, sorry. So i'm leaving it open for someone else to look at it.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Hi Mary,

              The patch looks good.

              Just some comment regarding the description box, in my opinion when there's not description for the group, it shouldn't display the box at all.

              Other than that, this looks great.

              Thank you for fixing.

              Show
              rwijaya Rossiani Wijaya added a comment - Hi Mary, The patch looks good. Just some comment regarding the description box, in my opinion when there's not description for the group, it shouldn't display the box at all. Other than that, this looks great. Thank you for fixing.
              Hide
              lazydaisy Mary Evans added a comment -

              Thanks Rossiani, but that can be said of all themes as Base adds a 1px border round the description table. Perhaps that is something that needs to be addressed in core files as I am sure it happens in other places too where empty boxes have borders.

              Show
              lazydaisy Mary Evans added a comment - Thanks Rossiani, but that can be said of all themes as Base adds a 1px border round the description table. Perhaps that is something that needs to be addressed in core files as I am sure it happens in other places too where empty boxes have borders.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              I agree with you Mary, this should be fixed through the code. I'm creating an issue to fix the empty description (MDL-41378).

              Show
              rwijaya Rossiani Wijaya added a comment - I agree with you Mary, this should be fixed through the code. I'm creating an issue to fix the empty description ( MDL-41378 ).
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated to master and 25 - thanks Mary

              Show
              poltawski Dan Poltawski added a comment - Integrated to master and 25 - thanks Mary
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Definitely a good improvement thanks Mary - passing this now.

              Show
              samhemelryk Sam Hemelryk added a comment - Definitely a good improvement thanks Mary - passing this now.
              Hide
              damyon Damyon Wiese added a comment -

              There was a young man named McGee
              Who thought squashing bugs was easy
              He tried it one day
              And to his dismay
              The bug guts made his keyboard all greasy

              Thanks!

              This has issue has been fixed and released in Moodle.

              Show
              damyon Damyon Wiese added a comment - There was a young man named McGee Who thought squashing bugs was easy He tried it one day And to his dismay The bug guts made his keyboard all greasy Thanks! This has issue has been fixed and released in Moodle.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Jul/13