Moodle
  1. Moodle
  2. MDL-41364

Appalling apostrophe crime in moodle-core-notification

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: Future Dev
    • Fix Version/s: 2.6
    • Component/s: AJAX and JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      1. Do something that triggers this warning. (I noticed it when attempting an essay question that used the HTML editor and filepicker.)

      2. Look in the JavaScript console.

      3. Verify that you are relaxed, because there is no erroneous apostropy to send your blood pressure through the roof.

      Show
      1. Do something that triggers this warning. (I noticed it when attempting an essay question that used the HTML editor and filepicker.) 2. Look in the JavaScript console. 3. Verify that you are relaxed, because there is no erroneous apostropy to send your blood pressure through the roof.
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      "Its" should not have an apostrope. It is like "his" or "her", and not like "Andrew's".

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Tim Hunt added a comment -

            Fix ready for integration, I think.

            Show
            Tim Hunt added a comment - Fix ready for integration, I think.
            Hide
            Andrew Nicols added a comment -

            That fix looks spot-on Tim Hunt. My most humble apologies for such a heinous crime!

            Show
            Andrew Nicols added a comment - That fix looks spot-on Tim Hunt . My most humble apologies for such a heinous crime!
            Hide
            Damyon Wiese added a comment -

            Its' a good thing you caught this Tim. Its' the best fix I've seen today.

            Its' been integrated to master only.

            Show
            Damyon Wiese added a comment - Its' a good thing you caught this Tim. Its' the best fix I've seen today. Its' been integrated to master only.
            Hide
            Tim Hunt added a comment -

            Damyon, you are a sadist.

            Show
            Tim Hunt added a comment - Damyon, you are a sadist.
            Hide
            Sam Hemelryk added a comment -

            Wow, amazing change, my blood pressure remained steady during testing, passing this now.

            Show
            Sam Hemelryk added a comment - Wow, amazing change, my blood pressure remained steady during testing, passing this now.
            Hide
            Damyon Wiese added a comment -

            There was a young man named McGee
            Who thought squashing bugs was easy
            He tried it one day
            And to his dismay
            The bug guts made his keyboard all greasy

            Thanks!

            This has issue has been fixed and released in Moodle.

            Show
            Damyon Wiese added a comment - There was a young man named McGee Who thought squashing bugs was easy He tried it one day And to his dismay The bug guts made his keyboard all greasy Thanks! This has issue has been fixed and released in Moodle.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: