Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41383

File picker broken when zooming in and out of browser

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.6, 2.6.3, 2.7
    • 2.5.7, 2.6.4, 2.7.1
    • Themes
    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Hide

      On Clean or More, and Base or Standard, using both LTR(e.g. en) and RTL(e.g. he) languages:

      1. Visit a course.
      2. Click on 'Restore' under 'Course administration'.
      3. Ensure that your browser width is at least 787px wide (so that the file picker is not fullscreen) and that your browser's zoom is set to 100%.
        • Click on the button above the filearea.
          • Verify that the upload file form is displayed correctly and NOT below the file manager.
        • Zoom out to 75%.
          • Verify that the upload file form is still displayed correctly.
        • Close and re-open the upload file form.
          • Verify that the upload file form is still displayed correctly.
        • Zoom in to 125%.
          • Verify that the upload file form is still displayed correctly.
      4. Resize your browser to be less than 787px wide and refresh the page.
        • Click the button above the filearea.
          • Verify that the upload file form is displayed correctly in the fullscreen file manager.
        • Zoom out to 75%.
          • Verify that the upload file form is still displayed correctly.
        • Close and re-open the upload file form.
          • Verify that the upload file form is still displayed correctly.
        • Zoom in to 125%.
          • Verify that the upload file form is still displayed correctly.
        • Close the upload file form and zoom back out to 75%.
        • Open the upload file form.
        • With the upload file form open, resize your window to be more than 873px wide.
        • Verify that the upload file form doesn't break.
      Show
      On Clean or More, and Base or Standard, using both LTR(e.g. en) and RTL(e.g. he) languages: Visit a course. Click on 'Restore' under 'Course administration'. Ensure that your browser width is at least 787px wide (so that the file picker is not fullscreen) and that your browser's zoom is set to 100% . Click on the button above the filearea. Verify that the upload file form is displayed correctly and NOT below the file manager. Zoom out to 75%. Verify that the upload file form is still displayed correctly. Close and re-open the upload file form. Verify that the upload file form is still displayed correctly. Zoom in to 125%. Verify that the upload file form is still displayed correctly. Resize your browser to be less than 787px wide and refresh the page. Click the button above the filearea. Verify that the upload file form is displayed correctly in the fullscreen file manager. Zoom out to 75%. Verify that the upload file form is still displayed correctly. Close and re-open the upload file form. Verify that the upload file form is still displayed correctly. Zoom in to 125%. Verify that the upload file form is still displayed correctly. Close the upload file form and zoom back out to 75%. Open the upload file form. With the upload file form open, resize your window to be more than 873px wide. Verify that the upload file form doesn't break.

    Description

      This is only broken in master, I tested on 2.5 and it is fine.

      1. Ensure you are using the clean theme.
      2. Install the Hebrew language pack.
      3. Visit a course.
      4. Click on 'Restore' under 'Course administration'.
      5. In the URL add '&lang=he'.
      6. Click on the button above the filearea.
      7. Notice the upload file form is displayed below the file manager.
      8. Cry yourself to sleep.

      Previous master diff url was https://github.com/lazydaisy/moodle/compare/master...wip-MDL-41383_master (though nothing's there any more.)

      Attachments

        1. After fix 26 xoom 75% RTL.jpg
          After fix 26 xoom 75% RTL.jpg
          73 kB
        2. After fix 26 zoom 75%.jpg
          After fix 26 zoom 75%.jpg
          67 kB
        3. MDL-41383.png
          MDL-41383.png
          78 kB
        4. MDL-41383-rtl.jpg
          MDL-41383-rtl.jpg
          25 kB
        5. My private files.png
          My private files.png
          144 kB
        6. screenshot-1.jpg
          screenshot-1.jpg
          51 kB

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45561 Horizontal scroll broken in base/standard theme for RTL

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45528 File picker has extra blank row in toolbar in RTL

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-39851 Full screen popup for mobile (filepicker/activitychooser)

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42197 Filepicker content is displayed out of the filepicker when the user zooms out the browser window.

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43637 File Picker displays incorrectly if font size is too small.

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43469 File Picker window not displayed properly in Chrome

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36126 Error restoring a Moodle 1.9.x course to Moodle 2.x due to long filenames

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              jethac Jetha Chan
              markn Mark Nelson
              Jason Fowler Jason Fowler
              Damyon Wiese Damyon Wiese
              Michael de Raadt Michael de Raadt
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jul/14