Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41401

Misnamed method backup_base_optigroup_testcase::itest_wrong_creation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5.1, 2.6
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Backup, Unit tests
    • Labels:
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41401-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Run phpunit backup/util/structure/tests/baseoptiogroup_test.php before the patch
        # Make a note of the number of tests run
      2. Run phpunit backup/util/structure/tests/baseoptiogroup_test.php after the patch
      3. VERIFY: more tests ran than before
      Show
      Run phpunit backup/util/structure/tests/baseoptiogroup_test.php before the patch # Make a note of the number of tests run Run phpunit backup/util/structure/tests/baseoptiogroup_test.php after the patch VERIFY: more tests ran than before

      Description

      While playing with MDLSITE-2398 I discovered this method was misnamed and will not be being run by phpunit.

      Looks like a vim typo will be causing it not be executed.

        Attachments

          Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-2398 Detect assertions in methods not named test*

          • Low - Cosmetic problems, nice-to-have features
          • Open

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              David Monllaó David Monllaó
              Integrator:
              Damyon Wiese Damyon Wiese
              Tester:
              Adrian Greeve Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13