Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41410

MDL-38162 misses to move the comment to the code too

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5.1, 2.6
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide

      No special testing should be required except:

      1. to verify that comments are in the rigth place in the code
      2. running:

        $ php -l cache/stores/memcache/lib.php
        $ php -l cache/stores/memcached/lib.php
        

        to verify the absence of broken sintax issues.

      Show
      No special testing should be required except: to verify that comments are in the rigth place in the code running: $ php -l cache/stores/memcache/lib.php $ php -l cache/stores/memcached/lib.php to verify the absence of broken sintax issues.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m26_MDL-41410_Move_Comment_To_Appropriate_Place

      Gliffy Diagrams

        Attachments

          Activity

          Hide
          matteo Matteo Scaramuccia added a comment -

          Hi Sam,
          this is really a trivial issue found just before my holidays, on re-reading the MUC code after some discussions/pointers from the Community and the Tracker. There should be another trivial issue about the (my) usage of double quotes in:

          ...
          $this->isready = @$this->connection->set("ping", 'ping', 1);
          ...
          

          but I'll leave it for some basic code cleanup one day, maybe.

          I think that even this PR is too trivial for your precious time so feel free to optionally drop it .

          Show
          matteo Matteo Scaramuccia added a comment - Hi Sam, this is really a trivial issue found just before my holidays, on re-reading the MUC code after some discussions/pointers from the Community and the Tracker. There should be another trivial issue about the (my) usage of double quotes in: ... $this->isready = @$this->connection->set("ping", 'ping', 1); ... but I'll leave it for some basic code cleanup one day, maybe. I think that even this PR is too trivial for your precious time so feel free to optionally drop it .
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Looks perfect thanks Matteo - putting this straight up for integration review.

          Show
          samhemelryk Sam Hemelryk added a comment - Looks perfect thanks Matteo - putting this straight up for integration review.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated (24, 25 & master), thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          And passed, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - And passed, thanks!
          Hide
          damyon Damyon Wiese added a comment -

          There was a young man named McGee
          Who thought squashing bugs was easy
          He tried it one day
          And to his dismay
          The bug guts made his keyboard all greasy

          Thanks!

          This has issue has been fixed and released in Moodle.

          Show
          damyon Damyon Wiese added a comment - There was a young man named McGee Who thought squashing bugs was easy He tried it one day And to his dismay The bug guts made his keyboard all greasy Thanks! This has issue has been fixed and released in Moodle.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13