Moodle
  1. Moodle
  2. MDL-41410

MDL-38162 misses to move the comment to the code too

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5.1, 2.6
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Caching
    • Labels:
    • Rank:
      52423

      Activity

      Hide
      Matteo Scaramuccia added a comment -

      Hi Sam,
      this is really a trivial issue found just before my holidays, on re-reading the MUC code after some discussions/pointers from the Community and the Tracker. There should be another trivial issue about the (my) usage of double quotes in:

      ...
      $this->isready = @$this->connection->set("ping", 'ping', 1);
      ...
      

      but I'll leave it for some basic code cleanup one day, maybe.

      I think that even this PR is too trivial for your precious time so feel free to optionally drop it .

      Show
      Matteo Scaramuccia added a comment - Hi Sam, this is really a trivial issue found just before my holidays, on re-reading the MUC code after some discussions/pointers from the Community and the Tracker. There should be another trivial issue about the (my) usage of double quotes in: ... $ this ->isready = @$ this ->connection->set( "ping" , 'ping', 1); ... but I'll leave it for some basic code cleanup one day, maybe. I think that even this PR is too trivial for your precious time so feel free to optionally drop it .
      Hide
      Sam Hemelryk added a comment -

      Looks perfect thanks Matteo - putting this straight up for integration review.

      Show
      Sam Hemelryk added a comment - Looks perfect thanks Matteo - putting this straight up for integration review.
      Hide
      Eloy Lafuente (stronk7) added a comment -

      Integrated (24, 25 & master), thanks!

      Show
      Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks!
      Hide
      Eloy Lafuente (stronk7) added a comment -

      And passed, thanks!

      Show
      Eloy Lafuente (stronk7) added a comment - And passed, thanks!
      Hide
      Damyon Wiese added a comment -

      There was a young man named McGee
      Who thought squashing bugs was easy
      He tried it one day
      And to his dismay
      The bug guts made his keyboard all greasy

      Thanks!

      This has issue has been fixed and released in Moodle.

      Show
      Damyon Wiese added a comment - There was a young man named McGee Who thought squashing bugs was easy He tried it one day And to his dismay The bug guts made his keyboard all greasy Thanks! This has issue has been fixed and released in Moodle.

        People

        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: