Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41437

missing plugins are not displayed on plugins overview page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Administration, Quiz
    • Labels:
    • Testing Instructions:
      Hide

      0/ run phpunit tests
      1/ install moodle (web and cli)
      2/ upgrade from 2.2 and 2.5
      3/ bump up main version.php and verify the site upgrades
      4/ bump up some plugin version.php and verify the site upgrades
      5/ uninstall some plugin without deleting php files (repeat with module, block and anything else)
      6/ uninstall some plugin with deleting of files (repeat with module, block and anything else)
      7/ manually delete some plugin files without uninstallation (repeat with module, block and anything else)
      8/ install and uninstall some add-ons
      9/ verify atto editor works
      10/ try enabling and disabling of modules, blocks and tinymce editor subplugins for example
      11/ backup and restore some course with modules and blocks

      Show
      0/ run phpunit tests 1/ install moodle (web and cli) 2/ upgrade from 2.2 and 2.5 3/ bump up main version.php and verify the site upgrades 4/ bump up some plugin version.php and verify the site upgrades 5/ uninstall some plugin without deleting php files (repeat with module, block and anything else) 6/ uninstall some plugin with deleting of files (repeat with module, block and anything else) 7/ manually delete some plugin files without uninstallation (repeat with module, block and anything else) 8/ install and uninstall some add-ons 9/ verify atto editor works 10/ try enabling and disabling of modules, blocks and tinymce editor subplugins for example 11/ backup and restore some course with modules and blocks
    • Workaround:
      Hide

      none

      Show
      none
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w39_MDL-41437_m26_mia
    • Story Points:
      20
    • Sprint:
      BACKEND Sprint 5

      Description

      1/ modules and blocks tell you when there are plugins that were not uninstalled properly, but other types of plugins do not
      we need to look for versions in config_plguins table... this creates multiple problems because there are leftovers in multiple core tables and admin can not easily force uninstall

      2/ plugin_manager class should be used strictly for management of plugins, for everything else it is huge, slow and often even incorrect because the get_plugins method returns even uninstalled modules and blocks. The solution is to use core_component which is extremely fast compared to plugin_manager abstraction.

      3/ Another problem is that modules and blocks store version info in special db tables instead of standard config_plugins table.

      4/ review plugin_manager performance and caching

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              skodak Petr Skoda
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13