Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41446

Completion: Incorrectly marks complete when grade data present with no actual grade

    Details

    • Testing Instructions:
      Hide

      0. turn on completion systemwide and for course.
      1. add new assignment, set to online text, complete automatically when user achieves grade.
      2. edit gradebook, grade settings, select the settings for the assignment grade, select pass grade 50
      3. if necessary, enrol a test student account in the course.

      4. log in to course as the test student.

      EXPECTED: Completion tickbox shows dotted outline with nothing in (=not completed).

      5. go into the assignment, type something, submit it, and return to course page.

      EXPECTED: The completion tickbox next to the assignment should still show the dotted outline and no X or tick

      6. log out as the student. log in as admin. Grade the submitted assignment as 40 (fail)

      7. log out as admin. log in as the student. Look at course page.

      EXPECTED: The completion tickbox next to the assignment should now show an X inside the dotted outline.

      Show
      0. turn on completion systemwide and for course. 1. add new assignment, set to online text, complete automatically when user achieves grade. 2. edit gradebook, grade settings, select the settings for the assignment grade, select pass grade 50 3. if necessary, enrol a test student account in the course. 4. log in to course as the test student. EXPECTED: Completion tickbox shows dotted outline with nothing in (=not completed). 5. go into the assignment, type something, submit it, and return to course page. EXPECTED: The completion tickbox next to the assignment should still show the dotted outline and no X or tick 6. log out as the student. log in as admin. Grade the submitted assignment as 40 (fail) 7. log out as admin. log in as the student. Look at course page. EXPECTED: The completion tickbox next to the assignment should now show an X inside the dotted outline.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-41446-master

      Description

      Add an assignment to a course with these global and particular settings:

      1. In Site administration > Advanced features:
      Enable completion tracking and conditional access.

      2. Course: Enable completion tracking.

      3.a. Add an assignment and set:
      Activity completion.
      Completion tracking:
      Require grade: Student must receive a grade to complete this activity.

      So, completion tracking must work like this:
      When the assignment is sent but not graded, the check box must remain empty until the assignment has a grade. Then, when is finally graded, it shows a blue tick no matter what grade it was.

      3.b. Add an extra condition to the assignment and set a 'Grade to pass'.

      So, completion tracking must work like this now:
      When the assignment is sent but not graded, the check box must remain empty until the assignment has a grade. Then, when is finally graded, it must show a green tick if it pass or a red cross if it fail, but actually it works this other way:
      When the assignment is sent, immediately it shows a red cross instead of remaining empty until it was graded.

      I actually left a previous message in assignment forum (https://moodle.org/mod/forum/discuss.php?d=235244#p1021700) but I guess this is the right place instead.
      Thanks!

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14