Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41466

Action icon are no longer right aligned in course page and in the section for activity of the home page.

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.6
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Switch to formal_white
      Go to the home page
      Add a section for activities
      Add an activity
      Start editing
      Look at the page: action icon should appear right aligned in the page

      Go to a course with activities
      Start editing
      Look at the page: action icon should appear right aligned in the page

      Show
      Switch to formal_white Go to the home page Add a section for activities Add an activity Start editing Look at the page: action icon should appear right aligned in the page Go to a course with activities Start editing Look at the page: action icon should appear right aligned in the page
    • Affected Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41466_master

      Description

      Since a long time formal_white has action icons right aligned in the course page but recently they were moved back to left.
      They may appear not nice to see.
      See attachements for details explaining better the issue.

        Gliffy Diagrams

          Activity

          Hide
          poltawski Dan Poltawski added a comment -

          Hi Daniele,

          I like this change.. however i'm going to reopen this because I don't think doing this solely in the formal white theme is the right solution.

          1. I think that we should be doing this for all themes, not just formal white. So rather than this formal white specific solution, we need to be looking at the core solution. I checked with Barbara Ramiro and she shares my thoughts.
          2. We need to check this with activity completion too.
          Show
          poltawski Dan Poltawski added a comment - Hi Daniele, I like this change.. however i'm going to reopen this because I don't think doing this solely in the formal white theme is the right solution. I think that we should be doing this for all themes, not just formal white. So rather than this formal white specific solution, we need to be looking at the core solution. I checked with Barbara Ramiro and she shares my thoughts. We need to check this with activity completion too.
          Hide
          cibot CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          daniss Daniele Cordella added a comment -

          Mary,
          do you have an idea about how to spread out this fix at general level?
          @Dan: I am the maintainer of formal_white only. Why do you ask me to do what I do not know and will make in a rough way because I am not aware of details?

          Show
          daniss Daniele Cordella added a comment - Mary, do you have an idea about how to spread out this fix at general level? @Dan: I am the maintainer of formal_white only. Why do you ask me to do what I do not know and will make in a rough way because I am not aware of details?
          Hide
          poltawski Dan Poltawski added a comment -

          Hi Daniele,

          You do not need to necessarily do this. But if we just keep changing things in formal white when the core will be fixed then formal white will become a nightmare to maintain. Its better if we can fix it for all themes.

          Show
          poltawski Dan Poltawski added a comment - Hi Daniele, You do not need to necessarily do this. But if we just keep changing things in formal white when the core will be fixed then formal white will become a nightmare to maintain. Its better if we can fix it for all themes.
          Hide
          poltawski Dan Poltawski added a comment -

          Hi Daniele,

          You do not need to necessarily do this. But if we just keep changing things in formal white when the core will be fixed then formal white will become a nightmare to maintain. Its better if we can fix it for all themes.

          Show
          poltawski Dan Poltawski added a comment - Hi Daniele, You do not need to necessarily do this. But if we just keep changing things in formal white when the core will be fixed then formal white will become a nightmare to maintain. Its better if we can fix it for all themes.
          Hide
          lazydaisy Mary Evans added a comment -

          Ciao Daniele,
          I can fix this no problem.
          In breve, È opportuno fissare in tema di base, poiché colpisce ogni tema.

          Sorry I did not reply to your comment about the Mediterranean Moodle Moot unfortunately I will not be going this year.

          Show
          lazydaisy Mary Evans added a comment - Ciao Daniele, I can fix this no problem. In breve, È opportuno fissare in tema di base, poiché colpisce ogni tema. Sorry I did not reply to your comment about the Mediterranean Moodle Moot unfortunately I will not be going this year.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          @Dan,
          I am pushing this back for Integration Review as the fix Daniele submitted is correct for Formal White theme.

          Making global changes in theme/base would break the idea of having these edit icons inline with the Activity heading rather than beneath it as it was previously

          In Formal White's case the edit icons were previously on the right, now they are displaced so they need restyling to put them back in place.

          Please allow Daniele's fix to go through.
          Many thanks

          Show
          lazydaisy Mary Evans added a comment - - edited @Dan, I am pushing this back for Integration Review as the fix Daniele submitted is correct for Formal White theme. Making global changes in theme/base would break the idea of having these edit icons inline with the Activity heading rather than beneath it as it was previously In Formal White's case the edit icons were previously on the right, now they are displaced so they need restyling to put them back in place. Please allow Daniele's fix to go through. Many thanks
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi guys,

          I agree with your assessment of this issue. Those icons have in the past being aligned to the right in the formal_white theme and only the formal_white theme.
          As we've not decided to right align them by default I think this change is spot on.

          Before this gets integrated Daniele can you please inform me, does this need to be backported to 25 and 24?

          Many thanks
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Hi guys, I agree with your assessment of this issue. Those icons have in the past being aligned to the right in the formal_white theme and only the formal_white theme. As we've not decided to right align them by default I think this change is spot on. Before this gets integrated Daniele can you please inform me, does this need to be backported to 25 and 24? Many thanks Sam
          Hide
          lazydaisy Mary Evans added a comment -

          Hi Sam, I don't think back-porting is necessary, as this only came to light after the change with the icons I seem to recall Damyon and Fred (I think) or was it Andrew? discussing this, whether to have the icons block or inline? Or something along those lines. I think the idea was to make them look good on a Mobile.

          Show
          lazydaisy Mary Evans added a comment - Hi Sam, I don't think back-porting is necessary, as this only came to light after the change with the icons I seem to recall Damyon and Fred (I think) or was it Andrew? discussing this, whether to have the icons block or inline? Or something along those lines. I think the idea was to make them look good on a Mobile.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks guys, I tested and confirmed this morning that it did only indeed affect 2.6. I've updated the affects version and have integrated this now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks guys, I tested and confirmed this morning that it did only indeed affect 2.6. I've updated the affects version and have integrated this now
          Hide
          lazydaisy Mary Evans added a comment -

          Show
          lazydaisy Mary Evans added a comment -
          Hide
          fred Frédéric Massart added a comment -

          Sorry but I have to fail this issue, please look at the screenshots for an overview on what is not properly working.

          Cheers,
          Fred

          Show
          fred Frédéric Massart added a comment - Sorry but I have to fail this issue, please look at the screenshots for an overview on what is not properly working. Cheers, Fred
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi Daniele, will you get a chance to look at those issues that Fred has noted?
          If not no probs we can revert it and send it back for another round.

          Show
          samhemelryk Sam Hemelryk added a comment - Hi Daniele, will you get a chance to look at those issues that Fred has noted? If not no probs we can revert it and send it back for another round.
          Hide
          daniss Daniele Cordella added a comment -

          Ciao Sam
          for sure we have to revert it
          because I had no time to look at it.
          It will be for a new round. I am sorry.

          Show
          daniss Daniele Cordella added a comment - Ciao Sam for sure we have to revert it because I had no time to look at it. It will be for a new round. I am sorry.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          No probs Daniele, it's been reverted now and is all yours again.

          Show
          samhemelryk Sam Hemelryk added a comment - No probs Daniele, it's been reverted now and is all yours again.
          Hide
          cibot CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          lazydaisy Mary Evans added a comment - - edited

          Daniele Cordella
          Do you mant me to close this or are you intending to get it fixed before 2.6 is dropped when 2.8 is released?

          Show
          lazydaisy Mary Evans added a comment - - edited Daniele Cordella Do you mant me to close this or are you intending to get it fixed before 2.6 is dropped when 2.8 is released?
          Hide
          daniss Daniele Cordella added a comment -

          Ciao Mary and thanks for your comment.
          I feel this issue can be closed as "Not a bug" since I don't see any satisfying solution.

          Show
          daniss Daniele Cordella added a comment - Ciao Mary and thanks for your comment. I feel this issue can be closed as "Not a bug" since I don't see any satisfying solution.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: