[MDL-41468] Unable to remove a calendar from "Manage Calendar subscriptions" page, When in RTL mode - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Pull from Repository:
https://github.com/nadavkav/moodle/
Pull Main Branch:
~~MDL-41468~~_master
Pull Main Diff URL:
https://github.com/nadavkav/moodle/compare/MDL-41468_master
Workaround:

Hide

Temporarily, switching UI to English enables the user to click the english "Delete" button, which deletes the selected calendar.

Show
Temporarily, switching UI to English enables the user to click the english "Delete" button, which deletes the selected calendar.
Testing Instructions:
Hide

Switch language to Hebrew (or any non English language)

Navigate into a Calendar page

Click "Manage subscriptions"

Add a new calendar (from an .ics file or a link) - You can use the attached Hebrew holidays .ics calendar file.

After you see the calendar imported into Moodle...

Make sure you can delete it by clicking the "Delete" button
Show
Switch language to Hebrew (or any non English language) Navigate into a Calendar page Click "Manage subscriptions" Add a new calendar (from an .ics file or a link) - You can use the attached Hebrew holidays .ics calendar file. After you see the calendar imported into Moodle... Make sure you can delete it by clicking the "Delete" button

This is due to submit button param "action" which only accepts PARAM_ALPHA.
(We had/have this issue across Moodle with non-English languages)

CHanging:

$action = optional_param('action', '', PARAM_ALPHA);

To:

$action = optional_param('action', '', PARAM_RAW);

Fixes this issue.

duplicates

MDL-41485 Do not use string as value for action buttons in calendar manage subscriptions page

has been marked as being related by

MDL-35202 Unable to set a new grade or update old grade when using the new Assignment type (Assign) while in Hebrew UI

is duplicated by

MDL-41680 Remove subscription from calendar He (RTL) lang - no response

will be (partly) resolved by

MDL-41485 Do not use string as value for action buttons in calendar manage subscriptions page