Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41468

Unable to remove a calendar from "Manage Calendar subscriptions" page, When in RTL mode

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Duplicate
    • 2.5.1
    • None
    • Calendar
    • MOODLE_25_STABLE
    • MDL-41468_master
    • Hide

      Temporarily, switching UI to English enables the user to click the english "Delete" button, which deletes the selected calendar.

      Show
      Temporarily, switching UI to English enables the user to click the english "Delete" button, which deletes the selected calendar.
    • Hide
      1. Switch language to Hebrew (or any non English language)
      2. Navigate into a Calendar page
      3. Click "Manage subscriptions"
      4. Add a new calendar (from an .ics file or a link) - You can use the attached Hebrew holidays .ics calendar file.
      5. After you see the calendar imported into Moodle...
      6. Make sure you can delete it by clicking the "Delete" button
      Show
      Switch language to Hebrew (or any non English language) Navigate into a Calendar page Click "Manage subscriptions" Add a new calendar (from an .ics file or a link) - You can use the attached Hebrew holidays .ics calendar file. After you see the calendar imported into Moodle... Make sure you can delete it by clicking the "Delete" button

    Description

      This is due to submit button param "action" which only accepts PARAM_ALPHA.
      (We had/have this issue across Moodle with non-English languages)

      CHanging:

      $action = optional_param('action', '', PARAM_ALPHA);

      To:

      $action = optional_param('action', '', PARAM_RAW);

      Fixes this issue.

      Attachments

        Issue Links

          Activity

            People

              nadavkav Nadav Kavalerchik
              nadavkav Nadav Kavalerchik
              Ankit Agarwal Ankit Agarwal
              Damyon Wiese Damyon Wiese
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: