Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41504

Tidying up the new mod edit buttons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Preparation:

      • Create some course modules in a course
      • Enable completion tracking for some activities in the course

      With JavaScript enabled, and editing menus enabled:

      • Open a course
      • Turn editing on
      • Confirm that:
        • the editing icons are evenly spaced
        • the actionmenu drops down
        • mouse overing an item in the actionmenu causes it to be highlighted for it's full width
        • the activity instance icon is larger than the others
        • the whole line looks appropriate in terms of vertical alignment
        • the section edit icon is the same size
        • the section marker and hide icons are the same size
      • Make the window narrower
        • Confirm that the icons do not overlap

      Disable JavaScript in your browser and refresh the page

      • Confirm that:
        • the actionmenu icon is now hidden
        • the spacing between the move/hide/group icons is consistent with the rest of the icons
        • the activity instance icon is larger than the others
        • the whole line looks appropriate in terms of vertical alignment
        • the section edit icon is the same size
        • the section marker and hide icons are the same size
      • Make the window narrower
        • Confirm that the icons do not overlap

      Keep JavaScript disabled and disable the modeditingmenu in site config

      • Repeat the previous set of instructions

      Re-enable JavaScript disabled and keep modeditingmenu disabled

      • Repeat the previous set of instructions

      Blocks:

      • Confirm that the move, update, and actionmenu icons are evently spaced from one another
      • Confirm that they're the same size (smaller than course module editing icons

      Confirm these changes in RTL as well as LTR.

      Show
      Preparation: Create some course modules in a course Enable completion tracking for some activities in the course With JavaScript enabled, and editing menus enabled: Open a course Turn editing on Confirm that: the editing icons are evenly spaced the actionmenu drops down mouse overing an item in the actionmenu causes it to be highlighted for it's full width the activity instance icon is larger than the others the whole line looks appropriate in terms of vertical alignment the section edit icon is the same size the section marker and hide icons are the same size Make the window narrower Confirm that the icons do not overlap Disable JavaScript in your browser and refresh the page Confirm that: the actionmenu icon is now hidden the spacing between the move/hide/group icons is consistent with the rest of the icons the activity instance icon is larger than the others the whole line looks appropriate in terms of vertical alignment the section edit icon is the same size the section marker and hide icons are the same size Make the window narrower Confirm that the icons do not overlap Keep JavaScript disabled and disable the modeditingmenu in site config Repeat the previous set of instructions Re-enable JavaScript disabled and keep modeditingmenu disabled Repeat the previous set of instructions Blocks: Confirm that the move, update, and actionmenu icons are evently spaced from one another Confirm that they're the same size (smaller than course module editing icons Confirm these changes in RTL as well as LTR.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-41504-master
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 6

      Description

      There are couple of things that look slightly unfinished with new modules editing buttons.

      1. With $CFG->modeditingmenu off the spacing between icons is uneven (see screenshot)
      2. With $CFG->modeditingmenu on the open menu does not close after selecting an item from it. Especially inconvinient in case of clicking on buttons to change identation. Or also menu stays open when one clicks "delete" and then "cancel"
      3. On narrow screen the module editing icons and completion icon don't like each other (attached screenshots in standard and clean themes).

      and last, it was probably discussed already, but could we make this button to toggle the menu and not only open? I would assume that this is what people are expecting. Thanks! - already requested in MDL-40976

        Attachments

        1. dropdown.png
          dropdown.png
          27 kB
        2. narrow_clean.png
          narrow_clean.png
          23 kB
        3. narrow_standard.png
          narrow_standard.png
          16 kB
        4. spacing.png
          spacing.png
          4 kB

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13