Moodle

LDAP Enrolment course creation default settings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4.5, 2.5.1, 2.6
  • Fix Version/s: 2.4.7, 2.5.3
  • Component/s: Enrolments
  • Labels:
  • Testing Instructions:
    Hide

    1/ configure ldap sync with an LDAP server
    2/ configure mapping for shortname, fullname and idnumber of courses
    3/ enable course auto creation
    4/ set enablecompletion=yes on course default settings
    5/ create a course in the ldap server
    6/ run cli script enrol/ldap/cli/sync.php
    7/ make sure the Enable completion tracking is set on the new course's settings page (You might have to enable the feature on the site level first to be able to see the setting in the course)

    Show
    1/ configure ldap sync with an LDAP server 2/ configure mapping for shortname, fullname and idnumber of courses 3/ enable course auto creation 4/ set enablecompletion=yes on course default settings 5/ create a course in the ldap server 6/ run cli script enrol/ldap/cli/sync.php 7/ make sure the Enable completion tracking is set on the new course's settings page (You might have to enable the feature on the site level first to be able to see the setting in the course)
  • Affected Branches:
    MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE, MOODLE_25_STABLE
  • Pull from Repository:
  • Pull 2.4 Branch:
    MDL-41528_MOODLE_24_STABLE
  • Pull 2.4 Diff URL:
  • Pull 2.5 Branch:
    MDL-41528_MOODLE_25_STABLE
  • Pull 2.5 Diff URL:
  • Pull Master Branch:
    MDL-41528_master
  • Pull Master Diff URL:

Description

When not using a course as a template for new LDAP courses enable completion tracking is missing

In addition groupmodeforce is set twice.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Thanks for working on that, Nitzan.

When you think it is ready, feel free to send this to peer review. Don't forget the testing instructions.

Show
Michael de Raadt added a comment - Thanks for working on that, Nitzan. When you think it is ready, feel free to send this to peer review. Don't forget the testing instructions.
Hide
Permalink
Nitzan Bar added a comment -

Michael de Raadt, I am submitting this to you since I do not know who should peer review this.

Thanks!

Show
Nitzan Bar added a comment - Michael de Raadt , I am submitting this to you since I do not know who should peer review this. Thanks!
Hide
Permalink
Michael de Raadt added a comment -

Hi, Nitzan.

Thanks for working on this.

It's not necessary to assign a peer reviewer when you push an issue for peer review and I'm certainly not the best person to peer review it.

I've added Iñaki Arenaza as a watcher on this issue and he may be willing to do a peer review.

Iñaki: you may have an ally in your fight for (against) LDAP.

Show
Michael de Raadt added a comment - Hi, Nitzan. Thanks for working on this. It's not necessary to assign a peer reviewer when you push an issue for peer review and I'm certainly not the best person to peer review it. I've added Iñaki Arenaza as a watcher on this issue and he may be willing to do a peer review. Iñaki: you may have an ally in your fight for (against) LDAP.
Hide
Permalink
Dan Poltawski added a comment -

Hi Nitzan,

Thanks for the perfect patch, i'm sending this for integration.

It would be good to write in the testing instructions what is expected to happen to verify the change is correct.

thanks!

Dan

Show
Dan Poltawski added a comment - Hi Nitzan, Thanks for the perfect patch, i'm sending this for integration. It would be good to write in the testing instructions what is expected to happen to verify the change is correct. thanks! Dan
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Nitzan this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Nitzan this has been integrated now.
Hide
Permalink
Ankit Agarwal added a comment -

works as described.

Show
Ankit Agarwal added a comment - works as described.
Hide
Permalink
Damyon Wiese added a comment -

This issue along with 77 of it's friends has been sent upstream and released to the world.

Thankyou for your contribution.

Show
Damyon Wiese added a comment - This issue along with 77 of it's friends has been sent upstream and released to the world. Thankyou for your contribution.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: